From: alexander.levin@verizon.com
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Cc: Stuart Hayes <stuart.w.hayes@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
alexander.levin@verizon.com
Subject: [PATCH AUTOSEL for 3.18 32/40] PCI: Create SR-IOV virtfn/physfn links before attaching driver
Date: Wed, 13 Dec 2017 01:59:19 +0000 [thread overview]
Message-ID: <20171213015905.7059-32-alexander.levin@verizon.com> (raw)
In-Reply-To: <20171213015905.7059-1-alexander.levin@verizon.com>
From: Stuart Hayes <stuart.w.hayes@gmail.com>
[ Upstream commit 27d6162944b9b34c32cd5841acd21786637ee743 ]
When creating virtual functions, create the "virtfn%u" and "physfn" links
in sysfs *before* attaching the driver instead of after. When we attach
the driver to the new virtual network interface first, there is a race when
the driver attaches to the new sends out an "add" udev event, and the
network interface naming software (biosdevname or systemd, for example)
tries to look at these links.
Signed-off-by: Stuart Hayes <stuart.w.hayes@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
---
drivers/pci/iov.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
index 4d109c07294a..9c0254638cc8 100644
--- a/drivers/pci/iov.c
+++ b/drivers/pci/iov.c
@@ -106,7 +106,6 @@ static int virtfn_add(struct pci_dev *dev, int id, int reset)
pci_device_add(virtfn, virtfn->bus);
mutex_unlock(&iov->dev->sriov->lock);
- pci_bus_add_device(virtfn);
sprintf(buf, "virtfn%u", id);
rc = sysfs_create_link(&dev->dev.kobj, &virtfn->dev.kobj, buf);
if (rc)
@@ -117,6 +116,8 @@ static int virtfn_add(struct pci_dev *dev, int id, int reset)
kobject_uevent(&virtfn->dev.kobj, KOBJ_CHANGE);
+ pci_bus_add_device(virtfn);
+
return 0;
failed2:
--
2.11.0
next prev parent reply other threads:[~2017-12-13 2:07 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 1:59 [PATCH AUTOSEL for 3.18 01/40] ALSA: hda - add support for docking station for HP 820 G2 alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 02/40] cpuidle: Validate cpu_dev in cpuidle_add_sysfs() alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 03/40] r8152: fix the list rx_done may be used without initialization alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 05/40] net: qmi_wwan: Add USB IDs for MDM6600 modem on Motorola Droid 4 alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 06/40] usb: gadget: f_uvc: Sanity check wMaxPacketSize for SuperSpeed alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 04/40] crypto: deadlock between crypto_alg_sem/rtnl_mutex/genl_mutex alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 07/40] usb: gadget: udc: remove pointer dereference after free alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 11/40] KVM: x86: correct async page present tracepoint alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 10/40] scsi: lpfc: Fix PT2PT PRLI reject alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 09/40] netfilter: nfnl_cthelper: Fix memory leak alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 08/40] netfilter: nfnl_cthelper: fix runtime expectation policy updates alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 14/40] i2c: mux: pca954x: Add missing pca9546 definition to chip_desc alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 13/40] hwmon: (asus_atk0110) fix uninitialized data access alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 12/40] ARM: dts: ti: fix PCI bus dtc warnings alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 15/40] HID: xinmo: fix for out of range for THT 2P arcade controller alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 17/40] net: Do not allow negative values for busy_read and busy_poll sysctl interfaces alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 16/40] s390/qeth: no ETH header for outbound AF_IUCV alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 19/40] irda: vlsi_ir: fix check for DMA mapping errors alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 18/40] i40e: Do not enable NAPI on q_vectors that have no rings alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 23/40] isdn: kcapi: avoid uninitialized data alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 21/40] netfilter: nf_nat_snmp: Fix panic when snmp_trap_helper fails to register alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 22/40] ARM: dts: am335x-evmsk: adjust mmc2 param to allow suspend alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 20/40] netfilter: nfnl_cthelper: fix a race when walk the nf_ct_helper_hash table alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 25/40] ARM: dma-mapping: disallow dma_get_sgtable() for non-kernel managed memory alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 24/40] xhci: plat: Register shutdown for xhci_plat alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 27/40] backlight: pwm_bl: Fix overflow condition alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 26/40] cpuidle: powernv: Pass correct drv->cpumask for registration alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 31/40] scsi: cxgb4i: fix Tx skb leak alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 30/40] PCI: Avoid bus reset if bridge itself is broken alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 29/40] net: phy: at803x: Change error to EINVAL for invalid MAC alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 28/40] crypto: crypto4xx - increase context and scatter ring buffer elements alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 34/40] PCI/AER: Report non-fatal errors only to the affected endpoint alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 35/40] percpu: don't forget to free the temporary struct pcpu_alloc_info alexander.levin
2017-12-13 1:59 ` alexander.levin [this message]
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 33/40] igb: check memory allocation failure alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 38/40] scsi: lpfc: PLOGI failures during NPIV testing alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 39/40] fm10k: ensure we process SM mbx when processing VF mbx alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 36/40] powerpc/xmon: Avoid tripping SMP hardlockup watchdog alexander.levin
2017-12-13 13:10 ` Michael Ellerman
2017-12-13 13:44 ` alexander.levin
2018-01-30 4:35 ` Michael Ellerman
2018-02-03 5:58 ` Nicholas Piggin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 37/40] scsi: lpfc: Fix secure firmware updates alexander.levin
2017-12-13 1:59 ` [PATCH AUTOSEL for 3.18 40/40] tcp: fix under-evaluated ssthresh in TCP Vegas alexander.levin
2017-12-21 9:54 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213015905.7059-32-alexander.levin@verizon.com \
--to=alexander.levin@verizon.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®