From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Michal Hocko <mhocko@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm, hugetlbfs: include mm.h for vm_operations_struct
Date: Wed, 13 Dec 2017 11:36:57 +1100 [thread overview]
Message-ID: <20171213113657.6a4640ec@canb.auug.org.au> (raw)
In-Reply-To: <CAPcyv4iQWzTkrayubb32CNrYqOV77-hAC_JajZpQ0pmzoXuE+A@mail.gmail.com>
Hi Dan,
On Tue, 12 Dec 2017 00:05:08 -0800 Dan Williams <dan.j.williams@intel.com> wrote:
>
> On Mon, Dec 11, 2017 at 11:47 PM, Michal Hocko <mhocko@kernel.org> wrote:
> > On Mon 11-12-17 17:21:27, Arnd Bergmann wrote:
> >> The infiniband umem code causes a build failure in some configurations:
> >>
> >> In file included from drivers/infiniband/core/umem_odp.c:41:0:
> >> include/linux/hugetlb.h: In function 'vma_kernel_pagesize':
> >> include/linux/hugetlb.h:262:32: error: dereferencing pointer to incomplete type 'const struct vm_operations_struct'
> >>
> >> Including the header file that defines the structure is sufficient to
> >> avoid this.
> >>
> >> Fixes: ac9284a6b670 ("mm, hugetlbfs: introduce ->pagesize() to vm_operations_struct")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > I've tried to do the same but the compilation failed for other
> > arches/configs. See http://lkml.kernel.org/r/20171210113715.GE20234@dhcp22.suse.cz
>
> Andrew, Stephen, please drop this ->pagesize() patch out of -mm and
> -next. I'll circle back once I have this include dependency fixed up.
> Thanks for the reports and sorry for the noise.
I have removed commits:
ac9284a6b670 ("mm, hugetlbfs: introduce ->pagesize() to vm_operations_struct")
d8115c6f55a0 ("device-dax: implement ->pagesize() for smaps to report MMUPageSize")
from my copy of the mmotm tree from today.
--
Cheers,
Stephen Rothwell
next prev parent reply other threads:[~2017-12-13 0:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 16:21 Arnd Bergmann
2017-12-12 0:55 ` Stephen Rothwell
2017-12-12 7:47 ` Michal Hocko
2017-12-12 8:05 ` Dan Williams
2017-12-13 0:36 ` Stephen Rothwell [this message]
2017-12-12 11:48 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213113657.6a4640ec@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®