From: Dan Carpenter <dan.carpenter@oracle.com>
To: Valentin Vidic <Valentin.Vidic@CARNet.hr>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
"Marcin Ciupak" <marcin.s.ciupak@gmail.com>,
"Marcus Wolf" <linux@wolf-entwicklungen.de>,
"Simon Sandström" <simon@nikanor.nu>
Subject: Re: [PATCH 2/8] staging: pi433: move var declaration to function level
Date: Wed, 13 Dec 2017 17:47:45 +0300 [thread overview]
Message-ID: <20171213144745.tzb2kaeivxb6sz4n@mwanda> (raw)
In-Reply-To: <20171213142156.3201-2-Valentin.Vidic@CARNet.hr>
On Wed, Dec 13, 2017 at 03:21:50PM +0100, Valentin Vidic wrote:
> Fixes checkpatch warning:
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Valentin Vidic <Valentin.Vidic@CARNet.hr>
> ---
> drivers/staging/pi433/pi433_if.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index 02887988d2ea..07e5352ae5ad 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -565,6 +565,7 @@ pi433_tx_thread(void *data)
> bool rx_interrupted = false;
> int position, repetitions;
> int retval;
> + int temp;
Generally, "temp" means "temperature" and "tmp" means "temporary". The
kernel deals with both. Btw "buff" means an 80s dude in a sleeveless
shirt and "buf" means a buffer, but the kernel doesn't deal with 80's
dudes so that one is less confusing.
But the name "tmp" still isn't really ideal here.
regards,
dan carpenter
next prev parent reply other threads:[~2017-12-13 14:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 14:21 [PATCH 1/8] staging: pi433: collapse else block after return statement Valentin Vidic
2017-12-13 14:21 ` [PATCH 2/8] staging: pi433: move var declaration to function level Valentin Vidic
2017-12-13 14:47 ` Dan Carpenter [this message]
2017-12-13 15:57 ` [PATCH 2/8 v2] " Valentin Vidic
2017-12-13 19:01 ` [PATCH 2/8] " Joe Perches
2017-12-13 19:46 ` [PATCH 2/8 v3] staging: pi433: cleanup local variable declaration Valentin Vidic
2017-12-13 14:21 ` [PATCH 3/8] staging: pi433: replace unsigned with unsigned int Valentin Vidic
2017-12-13 14:21 ` [PATCH 4/8] staging: pi433: add parentheses to mask and shift Valentin Vidic
2017-12-13 14:49 ` Dan Carpenter
2017-12-13 15:24 ` Marcus Wolf
2017-12-13 14:21 ` [PATCH 5/8] staging: pi433: fix DATAMODUL_MODULATION_TYPE_OOK value Valentin Vidic
2017-12-13 14:36 ` Dan Carpenter
2017-12-13 14:21 ` [PATCH 6/8] staging: pi433: use defines for shifting register values Valentin Vidic
2017-12-13 15:32 ` Marcus Wolf
2017-12-13 16:55 ` [PATCH 6/8 v2] " Valentin Vidic
2017-12-13 17:15 ` Marcus Wolf
2017-12-13 17:44 ` [PATCH 6/8 v3] " Valentin Vidic
2017-12-13 17:52 ` Marcus Wolf
2017-12-14 14:42 ` Dan Carpenter
2017-12-14 15:20 ` [PATCH 6/8 v4] staging: pi433: remove unused function Valentin Vidic
2017-12-14 16:08 ` rf69_get_lna_gain Marcus Wolf
2017-12-14 18:13 ` rf69_get_lna_gain Simon Sandström
2017-12-19 14:12 ` [PATCH 6/8 v4] staging: pi433: remove unused function Greg Kroah-Hartman
2017-12-13 16:58 ` [PATCH 6/8] staging: pi433: use defines for shifting register values Valentin Vidic
2017-12-13 14:21 ` [PATCH 7/8] staging: pi433: avoid logging ENOMEM messages Valentin Vidic
2017-12-13 14:21 ` [PATCH 8/8] staging: pi433: replace printk calls with dev_dbg Valentin Vidic
2017-12-13 14:52 ` Dan Carpenter
2017-12-13 15:23 ` Valentin Vidic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213144745.tzb2kaeivxb6sz4n@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Valentin.Vidic@CARNet.hr \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@wolf-entwicklungen.de \
--cc=marcin.s.ciupak@gmail.com \
--cc=simon@nikanor.nu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®