* [PATCH] RDMA/bnxt_re: Remove redundant bnxt_qplib_disable_nq() call
@ 2017-11-14 12:50 Arvind Yadav
2017-12-13 17:37 ` Jason Gunthorpe
0 siblings, 1 reply; 4+ messages in thread
From: Arvind Yadav @ 2017-11-14 12:50 UTC (permalink / raw)
To: selvin.xavier, devesh.sharma, somnath.kotur,
sriharsha.basavapatna, dledford, sean.hefty, hal.rosenstock
Cc: linux-kernel, linux-rdma
The bnxt_qplib_disable_nq() call is redundant as it occurs
after 'goto fail' and hence it called twice. Remove it.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/infiniband/hw/bnxt_re/qplib_fp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
index e8afc47..bb7cf5e 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
@@ -409,7 +409,6 @@ int bnxt_qplib_enable_nq(struct pci_dev *pdev, struct bnxt_qplib_nq *nq,
if (rc) {
dev_err(&nq->pdev->dev,
"Failed to request IRQ for NQ: %#x", rc);
- bnxt_qplib_disable_nq(nq);
goto fail;
}
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: RDMA/bnxt_re: Remove redundant bnxt_qplib_disable_nq() call
2017-11-14 12:50 [PATCH] RDMA/bnxt_re: Remove redundant bnxt_qplib_disable_nq() call Arvind Yadav
@ 2017-12-13 17:37 ` Jason Gunthorpe
2017-12-19 11:10 ` Devesh Sharma
0 siblings, 1 reply; 4+ messages in thread
From: Jason Gunthorpe @ 2017-12-13 17:37 UTC (permalink / raw)
To: Arvind Yadav
Cc: selvin.xavier, devesh.sharma, somnath.kotur,
sriharsha.basavapatna, dledford, sean.hefty, hal.rosenstock,
linux-kernel, linux-rdma
On Tue, Nov 14, 2017 at 06:20:56PM +0530, Arvind Yadav wrote:
> The bnxt_qplib_disable_nq() call is redundant as it occurs
> after 'goto fail' and hence it called twice. Remove it.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> drivers/infiniband/hw/bnxt_re/qplib_fp.c | 1 -
> 1 file changed, 1 deletion(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: RDMA/bnxt_re: Remove redundant bnxt_qplib_disable_nq() call
2017-12-13 17:37 ` Jason Gunthorpe
@ 2017-12-19 11:10 ` Devesh Sharma
2017-12-19 11:17 ` Leon Romanovsky
0 siblings, 1 reply; 4+ messages in thread
From: Devesh Sharma @ 2017-12-19 11:10 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: Arvind Yadav, Selvin Xavier, Somnath Kotur,
Sriharsha Basavapatna, Doug Ledford, Sean Hefty, Hal Rosenstock,
LKML, linux-rdma
However delayed ack but still..thanks for supplying this fix.
Acked-by: Devesh Sharma <devesh.sharma@broadcom.com>
On Wed, Dec 13, 2017 at 11:07 PM, Jason Gunthorpe <jgg@ziepe.ca> wrote:
> On Tue, Nov 14, 2017 at 06:20:56PM +0530, Arvind Yadav wrote:
>> The bnxt_qplib_disable_nq() call is redundant as it occurs
>> after 'goto fail' and hence it called twice. Remove it.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>> drivers/infiniband/hw/bnxt_re/qplib_fp.c | 1 -
>> 1 file changed, 1 deletion(-)
>
> Applied to for-next, thanks
>
> Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: RDMA/bnxt_re: Remove redundant bnxt_qplib_disable_nq() call
2017-12-19 11:10 ` Devesh Sharma
@ 2017-12-19 11:17 ` Leon Romanovsky
0 siblings, 0 replies; 4+ messages in thread
From: Leon Romanovsky @ 2017-12-19 11:17 UTC (permalink / raw)
To: Devesh Sharma
Cc: Jason Gunthorpe, Arvind Yadav, Selvin Xavier, Somnath Kotur,
Sriharsha Basavapatna, Doug Ledford, Sean Hefty, Hal Rosenstock,
LKML, linux-rdma
[-- Attachment #1: Type: text/plain, Size: 952 bytes --]
On Tue, Dec 19, 2017 at 04:40:42PM +0530, Devesh Sharma wrote:
> However delayed ack but still..thanks for supplying this fix.
>
> Acked-by: Devesh Sharma <devesh.sharma@broadcom.com>
>
Devesh,
What should we do in order to stop you to answer in top-posting format?
Thanks
>
> On Wed, Dec 13, 2017 at 11:07 PM, Jason Gunthorpe <jgg@ziepe.ca> wrote:
> > On Tue, Nov 14, 2017 at 06:20:56PM +0530, Arvind Yadav wrote:
> >> The bnxt_qplib_disable_nq() call is redundant as it occurs
> >> after 'goto fail' and hence it called twice. Remove it.
> >>
> >> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> >> drivers/infiniband/hw/bnxt_re/qplib_fp.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >
> > Applied to for-next, thanks
> >
> > Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-19 11:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-14 12:50 [PATCH] RDMA/bnxt_re: Remove redundant bnxt_qplib_disable_nq() call Arvind Yadav
2017-12-13 17:37 ` Jason Gunthorpe
2017-12-19 11:10 ` Devesh Sharma
2017-12-19 11:17 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®