From: Steven Eckhoff <steven.eckhoff.opensource@gmail.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [alsa-devel] [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC
Date: Thu, 14 Dec 2017 16:43:10 -0600 [thread overview]
Message-ID: <20171214224309.btsuh3ew5lkqfpcf@localhost.localdomain> (raw)
In-Reply-To: <20171214222955.qicmzltikkwaazly@localhost.localdomain>
On Thu, Dec 14, 2017 at 04:36:17PM -0600, Steven Eckhoff wrote:
> On Thu, Dec 14, 2017 at 09:32:44AM +0000, Charles Keepax wrote:
>
> > Not sure what you mean here but setting up CODEC registers
> > directly from the machine driver is probably not ideal. You
> > should probably be looking into regmap_register_patch this lets
> > you apply a bunch of register settings to the chip every time you
> > do a regmap_cache_sync. This is useful for situations like the
> > chip has terrible register defaults you want to correct.
>
> Thanks I will keep that in mind. For now our defaults are okay, but
> this may come in handy in other drivers. I have removed this bit from
> the next version since this can be set by the machine driver and it
> makes more sense there since the settings were configuring how the I2S
> interfaces were connected.
I apologize I had to reread that.
The settings were setting whether the bclk and lrclk would be shared
between the DAC and ADC interfaces. I thought this would make sense in
the machine driver since it knows how the devices are connected. Is
there a better way to do this?
next prev parent reply other threads:[~2017-12-14 22:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 19:54 Steven Eckhoff
2017-12-12 13:04 ` Charles Keepax
2017-12-12 13:10 ` Takashi Iwai
2017-12-12 16:54 ` Steven Eckhoff
2017-12-12 16:35 ` Steven Eckhoff
2017-12-12 16:32 ` Mark Brown
2017-12-12 21:31 ` Steven Eckhoff
2017-12-12 22:51 ` Steven Eckhoff
2017-12-13 6:20 ` Steven Eckhoff
2017-12-13 10:47 ` Mark Brown
2017-12-13 15:40 ` Steven Eckhoff
2017-12-14 9:32 ` [alsa-devel] " Charles Keepax
2017-12-14 22:36 ` Steven Eckhoff
2017-12-14 22:43 ` Steven Eckhoff [this message]
2017-12-15 11:36 ` Charles Keepax
2017-12-15 16:08 ` Steven Eckhoff
2017-12-17 19:23 ` Steven Eckhoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214224309.btsuh3ew5lkqfpcf@localhost.localdomain \
--to=steven.eckhoff.opensource@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®