From: Joel Fernandes <joelaf@google.com>
To: linux-kernel@vger.kernel.org
Cc: Joel Fernandes <joelaf@google.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@arm.com>,
Patrick Bellasi <patrick.bellasi@arm.com>,
Chris Redpath <Chris.Redpath@arm.com>,
Steve Muckle <smuckle@google.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Morten Ramussen <morten.rasmussen@arm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
Saravana Kannan <skannan@quicinc.com>,
Vikram Mulukutla <markivx@codeaurora.org>,
Rohit Jain <rohit.k.jain@oracle.com>,
Atish Patra <atish.patra@oracle.com>, Josef Bacik <jbacik@fb.com>,
EAS Dev <eas-dev@lists.linaro.org>,
Android Kernel <kernel-team@android.com>
Subject: [PATCH 3/3] sched/fair: remove impossible condition from find_idlest_group_cpu
Date: Fri, 15 Dec 2017 07:39:44 -0800 [thread overview]
Message-ID: <20171215153944.220146-3-joelaf@google.com> (raw)
In-Reply-To: <20171215153944.220146-1-joelaf@google.com>
find_idlest_group_cpu goes through CPUs of a group previous selected by
find_idlest_group. find_idlest_group returns NULL if the local group is the
selected one and doesn't execute find_idlest_group_cpu if the group to which
'cpu' belongs to is chosen. So we're always guaranteed to call
find_idlest_group_cpu with a group to which cpu is non-local. This makes one of
the conditions in find_idlest_group_cpu an impossible one, which we can get rid
off.
Reviewed-by: Brendan Jackman <brendan.jackman@arm.com>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Joel Fernandes <joelaf@google.com>
---
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 1b10821d8380..44407e703b5f 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5948,7 +5948,7 @@ find_idlest_group_cpu(struct sched_group *group, struct task_struct *p, int this
}
} else if (shallowest_idle_cpu == -1) {
load = weighted_cpuload(cpu_rq(i));
- if (load < min_load || (load == min_load && i == this_cpu)) {
+ if (load < min_load) {
min_load = load;
least_loaded_cpu = i;
}
--
2.15.1.504.g5279b80103-goog
next prev parent reply other threads:[~2017-12-15 15:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 15:39 [PATCH 1/3] cpufreq: schedutil: Use idle_calls counter of the remote CPU Joel Fernandes
2017-12-15 15:39 ` [PATCH 2/3] sched/fair: Correct obsolete comment about cpufreq_update_util Joel Fernandes
2017-12-19 18:02 ` Peter Zijlstra
2018-01-10 12:16 ` [tip:sched/core] sched/fair: Correct obsolete comment about cpufreq_update_util() tip-bot for Joel Fernandes
2017-12-15 15:39 ` Joel Fernandes [this message]
2018-01-10 12:16 ` [tip:sched/core] sched/fair: Remove impossible condition from find_idlest_group_cpu() tip-bot for Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215153944.220146-3-joelaf@google.com \
--to=joelaf@google.com \
--cc=Chris.Redpath@arm.com \
--cc=atish.patra@oracle.com \
--cc=dietmar.eggemann@arm.com \
--cc=eas-dev@lists.linaro.org \
--cc=fweisbec@gmail.com \
--cc=jbacik@fb.com \
--cc=juri.lelli@arm.com \
--cc=kernel-team@android.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markivx@codeaurora.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=rohit.k.jain@oracle.com \
--cc=rostedt@goodmis.org \
--cc=skannan@quicinc.com \
--cc=smuckle@google.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome