mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Joel Fernandes <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, torvalds@linux-foundation.org,
	dietmar.eggemann@arm.com, joelaf@google.com, rostedt@goodmis.org,
	hpa@zytor.com, peterz@infradead.org, eas-dev@lists.linaro.org,
	atish.patra@oracle.com, skannan@quicinc.com,
	patrick.bellasi@arm.com, morten.rasmussen@arm.com,
	rjw@rjwysocki.net, smuckle@google.com, Chris.Redpath@arm.com,
	markivx@codeaurora.org, vincent.guittot@linaro.org,
	linux-kernel@vger.kernel.org, mingo@kernel.org,
	viresh.kumar@linaro.org, fweisbec@gmail.com,
	srinivas.pandruvada@linux.intel.com, juri.lelli@arm.com,
	rohit.k.jain@oracle.com, kernel-team@android.com,
	lenb@kernel.org, jbacik@fb.com
Subject: [tip:sched/core] sched/fair: Correct obsolete comment about cpufreq_update_util()
Date: Wed, 10 Jan 2018 04:16:29 -0800	[thread overview]
Message-ID: <tip-9783be2c0e90bbaceec3c471c4fb017bff7293ba@git.kernel.org> (raw)
In-Reply-To: <20171215153944.220146-2-joelaf@google.com>

Commit-ID:  9783be2c0e90bbaceec3c471c4fb017bff7293ba
Gitweb:     https://git.kernel.org/tip/9783be2c0e90bbaceec3c471c4fb017bff7293ba
Author:     Joel Fernandes <joelaf@google.com>
AuthorDate: Fri, 15 Dec 2017 07:39:43 -0800
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 10 Jan 2018 11:30:30 +0100

sched/fair: Correct obsolete comment about cpufreq_update_util()

Since the remote cpufreq callback work, the cpufreq_update_util() call can happen
from remote CPUs. The comment about local CPUs is thus obsolete. Update it
accordingly.

Signed-off-by: Joel Fernandes <joelaf@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Android Kernel <kernel-team@android.com>
Cc: Atish Patra <atish.patra@oracle.com>
Cc: Chris Redpath <Chris.Redpath@arm.com>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: EAS Dev <eas-dev@lists.linaro.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Josef Bacik <jbacik@fb.com>
Cc: Juri Lelli <juri.lelli@arm.com>
Cc: Len Brown <lenb@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Morten Ramussen <morten.rasmussen@arm.com>
Cc: Patrick Bellasi <patrick.bellasi@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Rohit Jain <rohit.k.jain@oracle.com>
Cc: Saravana Kannan <skannan@quicinc.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Steve Muckle <smuckle@google.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vikram Mulukutla <markivx@codeaurora.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Link: http://lkml.kernel.org/r/20171215153944.220146-2-joelaf@google.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/fair.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 3e7606d..59e66a5 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -3020,9 +3020,7 @@ static inline void cfs_rq_util_change(struct cfs_rq *cfs_rq)
 		/*
 		 * There are a few boundary cases this might miss but it should
 		 * get called often enough that that should (hopefully) not be
-		 * a real problem -- added to that it only calls on the local
-		 * CPU, so if we enqueue remotely we'll miss an update, but
-		 * the next tick/schedule should update.
+		 * a real problem.
 		 *
 		 * It will not get called when we go idle, because the idle
 		 * thread is a different class (!fair), nor will the utilization

  parent reply	other threads:[~2018-01-10 12:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15 15:39 [PATCH 1/3] cpufreq: schedutil: Use idle_calls counter of the remote CPU Joel Fernandes
2017-12-15 15:39 ` [PATCH 2/3] sched/fair: Correct obsolete comment about cpufreq_update_util Joel Fernandes
2017-12-19 18:02   ` Peter Zijlstra
2018-01-10 12:16   ` tip-bot for Joel Fernandes [this message]
2017-12-15 15:39 ` [PATCH 3/3] sched/fair: remove impossible condition from find_idlest_group_cpu Joel Fernandes
2018-01-10 12:16   ` [tip:sched/core] sched/fair: Remove impossible condition from find_idlest_group_cpu() tip-bot for Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-9783be2c0e90bbaceec3c471c4fb017bff7293ba@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=Chris.Redpath@arm.com \
    --cc=atish.patra@oracle.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=eas-dev@lists.linaro.org \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jbacik@fb.com \
    --cc=joelaf@google.com \
    --cc=juri.lelli@arm.com \
    --cc=kernel-team@android.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=markivx@codeaurora.org \
    --cc=mingo@kernel.org \
    --cc=morten.rasmussen@arm.com \
    --cc=patrick.bellasi@arm.com \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=rohit.k.jain@oracle.com \
    --cc=rostedt@goodmis.org \
    --cc=skannan@quicinc.com \
    --cc=smuckle@google.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome