From: Steven Eckhoff <steven.eckhoff.opensource@gmail.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org,
Philippe Ombredanne <pombredanne@nexb.com>,
Takashi Iwai <tiwai@suse.de>
Subject: Re: [alsa-devel][PATCH v6] ASoC: TSCS42xx: Support Tempo Semiconductor's TSCS42xx audio CODECs
Date: Mon, 18 Dec 2017 14:08:32 -0600 [thread overview]
Message-ID: <20171218195843.c4pp6ntsup2o4l5y@localhost.localdomain> (raw)
In-Reply-To: <20171218095048.e5zwla65f2qqmroj@localhost.localdomain>
On Mon, Dec 18, 2017 at 09:50:48AM +0000, Charles Keepax wrote:
> Is this unused?
I apologize I missed this. These were going to be mux controls for two
differential inputs. There are two inputs, but only one can be used at
a time. We have never seen anybody use the second input, so I will
remove the mux controls since it is likely just going to be noise to
anybody configuring the chip through these controls.
> Given all users of this macro use coeff_ram_get and coeff_ram_put
> might it just be worth sticking them in here?
Good point. In the next version the callbacks will be implied through
the use of the macro.
> Other than those two very minor comments, looks ok to me so I
> think you can add:
>
> Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
>
> Thanks,
> Charles
Thank you so much for your time on this review. It has really helped
improve the driver.
prev parent reply other threads:[~2017-12-18 20:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-17 3:54 Steven Eckhoff
2017-12-18 9:50 ` Charles Keepax
2017-12-18 20:08 ` Steven Eckhoff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218195843.c4pp6ntsup2o4l5y@localhost.localdomain \
--to=steven.eckhoff.opensource@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pombredanne@nexb.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®