* [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C925e
@ 2017-12-18 16:04 Dmitry Fleytman
2017-12-18 18:07 ` Kai-Heng Feng
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Fleytman @ 2017-12-18 16:04 UTC (permalink / raw)
Cc: Dmitry Fleytman Dmitry Fleytman, Greg Kroah-Hartman,
Felipe Balbi, Kai-Heng Feng, Alan Stern, Dmitry Fleytman,
Lukáš Lalinský,
Daniel Drake, Samuel Thibault, linux-usb, linux-kernel
From: Dmitry Fleytman Dmitry Fleytman <dmitry.fleytman@gmail.com>
Commit e0429362ab15
("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e")
introduced quirk to workaround an issue with some Logitech webcams.
There is one more model that has the same issue - C925e, so applying
the same quirk as well.
See aforementioned commit message for detailed explanation of the problem.
Signed-off-by: Dmitry Fleytman <dmitry.fleytman@gmail.com>
---
drivers/usb/core/quirks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index a10b346b9777..6d2d3b0bcc2a 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -52,10 +52,11 @@ static const struct usb_device_id usb_quirk_list[] = {
/* Microsoft LifeCam-VX700 v2.0 */
{ USB_DEVICE(0x045e, 0x0770), .driver_info = USB_QUIRK_RESET_RESUME },
- /* Logitech HD Pro Webcams C920, C920-C and C930e */
+ /* Logitech HD Pro Webcams C920, C920-C, C925e and C930e */
{ USB_DEVICE(0x046d, 0x082d), .driver_info = USB_QUIRK_DELAY_INIT },
{ USB_DEVICE(0x046d, 0x0841), .driver_info = USB_QUIRK_DELAY_INIT },
{ USB_DEVICE(0x046d, 0x0843), .driver_info = USB_QUIRK_DELAY_INIT },
+ { USB_DEVICE(0x046d, 0x085B), .driver_info = USB_QUIRK_DELAY_INIT },
/* Logitech ConferenceCam CC3000e */
{ USB_DEVICE(0x046d, 0x0847), .driver_info = USB_QUIRK_DELAY_INIT },
--
2.14.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C925e
2017-12-18 16:04 [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C925e Dmitry Fleytman
@ 2017-12-18 18:07 ` Kai-Heng Feng
2017-12-19 3:52 ` Dmitry Fleytman
0 siblings, 1 reply; 4+ messages in thread
From: Kai-Heng Feng @ 2017-12-18 18:07 UTC (permalink / raw)
To: Dmitry Fleytman
Cc: Greg Kroah-Hartman, Felipe Balbi, Alan Stern, Dmitry Fleytman,
Lukáš Lalinský,
Daniel Drake, Samuel Thibault, linux-usb, linux-kernel
Hi,
> On 19 Dec 2017, at 12:04 AM, Dmitry Fleytman <dmitry.fleytman@gmail.com> wrote:
>
> From: Dmitry Fleytman Dmitry Fleytman <dmitry.fleytman@gmail.com>
>
> Commit e0429362ab15
> ("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e")
> introduced quirk to workaround an issue with some Logitech webcams.
>
> There is one more model that has the same issue - C925e, so applying
> the same quirk as well.
>
> See aforementioned commit message for detailed explanation of the problem.
>
> Signed-off-by: Dmitry Fleytman <dmitry.fleytman@gmail.com>
> ---
> drivers/usb/core/quirks.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index a10b346b9777..6d2d3b0bcc2a 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -52,10 +52,11 @@ static const struct usb_device_id usb_quirk_list[] = {
> /* Microsoft LifeCam-VX700 v2.0 */
> { USB_DEVICE(0x045e, 0x0770), .driver_info = USB_QUIRK_RESET_RESUME },
>
> - /* Logitech HD Pro Webcams C920, C920-C and C930e */
> + /* Logitech HD Pro Webcams C920, C920-C, C925e and C930e */
> { USB_DEVICE(0x046d, 0x082d), .driver_info = USB_QUIRK_DELAY_INIT },
> { USB_DEVICE(0x046d, 0x0841), .driver_info = USB_QUIRK_DELAY_INIT },
> { USB_DEVICE(0x046d, 0x0843), .driver_info = USB_QUIRK_DELAY_INIT },
> + { USB_DEVICE(0x046d, 0x085B), .driver_info = USB_QUIRK_DELAY_INIT },
Nitpicking here, but maybe use 0x085b instead of 0x085B?
Kai-Heng
>
> /* Logitech ConferenceCam CC3000e */
> { USB_DEVICE(0x046d, 0x0847), .driver_info = USB_QUIRK_DELAY_INIT },
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C925e
2017-12-18 18:07 ` Kai-Heng Feng
@ 2017-12-19 3:52 ` Dmitry Fleytman
2017-12-19 4:02 ` [PATCH v2] " Dmitry Fleytman
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Fleytman @ 2017-12-19 3:52 UTC (permalink / raw)
To: Kai-Heng Feng
Cc: Greg Kroah-Hartman, Felipe Balbi, Alan Stern, dmitry,
Lukáš Lalinský,
Daniel Drake, Samuel Thibault, linux-usb, linux-kernel
> On 18 Dec 2017, at 20:07, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
>
> Hi,
>
>> On 19 Dec 2017, at 12:04 AM, Dmitry Fleytman <dmitry.fleytman@gmail.com> wrote:
>>
>> From: Dmitry Fleytman Dmitry Fleytman <dmitry.fleytman@gmail.com>
>>
>> Commit e0429362ab15
>> ("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e")
>> introduced quirk to workaround an issue with some Logitech webcams.
>>
>> There is one more model that has the same issue - C925e, so applying
>> the same quirk as well.
>>
>> See aforementioned commit message for detailed explanation of the problem.
>>
>> Signed-off-by: Dmitry Fleytman <dmitry.fleytman@gmail.com>
>> ---
>> drivers/usb/core/quirks.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
>> index a10b346b9777..6d2d3b0bcc2a 100644
>> --- a/drivers/usb/core/quirks.c
>> +++ b/drivers/usb/core/quirks.c
>> @@ -52,10 +52,11 @@ static const struct usb_device_id usb_quirk_list[] = {
>> /* Microsoft LifeCam-VX700 v2.0 */
>> { USB_DEVICE(0x045e, 0x0770), .driver_info = USB_QUIRK_RESET_RESUME },
>>
>> - /* Logitech HD Pro Webcams C920, C920-C and C930e */
>> + /* Logitech HD Pro Webcams C920, C920-C, C925e and C930e */
>> { USB_DEVICE(0x046d, 0x082d), .driver_info = USB_QUIRK_DELAY_INIT },
>> { USB_DEVICE(0x046d, 0x0841), .driver_info = USB_QUIRK_DELAY_INIT },
>> { USB_DEVICE(0x046d, 0x0843), .driver_info = USB_QUIRK_DELAY_INIT },
>> + { USB_DEVICE(0x046d, 0x085B), .driver_info = USB_QUIRK_DELAY_INIT },
>
> Nitpicking here, but maybe use 0x085b instead of 0x085B?
Yes. Sending v2...
>
> Kai-Heng
>
>>
>> /* Logitech ConferenceCam CC3000e */
>> { USB_DEVICE(0x046d, 0x0847), .driver_info = USB_QUIRK_DELAY_INIT },
>> --
>> 2.14.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] usb: Add device quirk for Logitech HD Pro Webcam C925e
2017-12-19 3:52 ` Dmitry Fleytman
@ 2017-12-19 4:02 ` Dmitry Fleytman
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Fleytman @ 2017-12-19 4:02 UTC (permalink / raw)
Cc: Dmitry Fleytman Dmitry Fleytman, Greg Kroah-Hartman, Alan Stern,
Felipe Balbi, Kai-Heng Feng, Dmitry Fleytman,
Lukáš Lalinský,
Bernhard Rosenkraenzer, Samuel Thibault, Daniel Drake,
Devin Heitmueller, linux-usb, linux-kernel
From: Dmitry Fleytman Dmitry Fleytman <dmitry.fleytman@gmail.com>
Commit e0429362ab15
("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e")
introduced quirk to workaround an issue with some Logitech webcams.
There is one more model that has the same issue - C925e, so applying
the same quirk as well.
See aforementioned commit message for detailed explanation of the problem.
Signed-off-by: Dmitry Fleytman <dmitry.fleytman@gmail.com>
---
drivers/usb/core/quirks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index a10b346b9777..848da96614e8 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -52,10 +52,11 @@ static const struct usb_device_id usb_quirk_list[] = {
/* Microsoft LifeCam-VX700 v2.0 */
{ USB_DEVICE(0x045e, 0x0770), .driver_info = USB_QUIRK_RESET_RESUME },
- /* Logitech HD Pro Webcams C920, C920-C and C930e */
+ /* Logitech HD Pro Webcams C920, C920-C, C925e and C930e */
{ USB_DEVICE(0x046d, 0x082d), .driver_info = USB_QUIRK_DELAY_INIT },
{ USB_DEVICE(0x046d, 0x0841), .driver_info = USB_QUIRK_DELAY_INIT },
{ USB_DEVICE(0x046d, 0x0843), .driver_info = USB_QUIRK_DELAY_INIT },
+ { USB_DEVICE(0x046d, 0x085b), .driver_info = USB_QUIRK_DELAY_INIT },
/* Logitech ConferenceCam CC3000e */
{ USB_DEVICE(0x046d, 0x0847), .driver_info = USB_QUIRK_DELAY_INIT },
--
2.14.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-19 4:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-18 16:04 [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C925e Dmitry Fleytman
2017-12-18 18:07 ` Kai-Heng Feng
2017-12-19 3:52 ` Dmitry Fleytman
2017-12-19 4:02 ` [PATCH v2] " Dmitry Fleytman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome