From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Dhaval Giani <dhaval.giani@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario
Date: Tue, 19 Dec 2017 11:52:38 -0500 [thread overview]
Message-ID: <20171219115238.03dc992c@gandalf.local.home> (raw)
In-Reply-To: <20171219164619.ehrsqvqajj4n6wr6@hirez.programming.kicks-ass.net>
On Tue, 19 Dec 2017 17:46:19 +0100
Peter Zijlstra <peterz@infradead.org> wrote:
> It really isn't that hard, Its mostly a question of TL;DR.
>
> #0 is useless and should be thrown out
> #1 shows where we take #1 while holding #0
> ..
> #n shows where we take #n while holding #n-1
>
> And the bottom callstack shows where we take #0 while holding #n. Which
> gets you a nice circle in your graph, which spells deadlock.
>
> Plenty people have shown they get this stuff.
Then I suggest that you can either take my patch to improve the
visual or remove the visual completely, as nobody cares about it.
-- Steve
next prev parent reply other threads:[~2017-12-19 16:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 17:38 Steven Rostedt
2017-12-14 17:59 ` Peter Zijlstra
2017-12-14 18:19 ` Steven Rostedt
2017-12-19 16:30 ` Dhaval Giani
2017-12-19 16:46 ` Peter Zijlstra
2017-12-19 16:52 ` Steven Rostedt [this message]
2017-12-19 16:54 ` Dhaval Giani
2017-12-19 17:10 ` Steven Rostedt
2017-12-19 17:07 ` Peter Zijlstra
2017-12-19 17:11 ` Steven Rostedt
2017-12-19 17:29 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219115238.03dc992c@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=dhaval.giani@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®