From: Steven Rostedt <rostedt@goodmis.org>
To: Dhaval Giani <dhaval.giani@oracle.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] lockdep: Show up to three levels for a deadlock scenario
Date: Tue, 19 Dec 2017 12:10:10 -0500 [thread overview]
Message-ID: <20171219121010.06ad6a73@gandalf.local.home> (raw)
In-Reply-To: <b5124ced-0f77-c6d6-72c1-f0e8db9b2fc7@oracle.com>
On Tue, 19 Dec 2017 11:54:10 -0500
Dhaval Giani <dhaval.giani@oracle.com> wrote:
> On 2017-12-19 11:52 AM, Steven Rostedt wrote:
> > On Tue, 19 Dec 2017 17:46:19 +0100
> > Peter Zijlstra <peterz@infradead.org> wrote:
> >
> >
> >> It really isn't that hard, Its mostly a question of TL;DR.
> >>
> >> #0 is useless and should be thrown out
> >> #1 shows where we take #1 while holding #0
> >> ..
> >> #n shows where we take #n while holding #n-1
> >>
> >> And the bottom callstack shows where we take #0 while holding #n. Which
> >> gets you a nice circle in your graph, which spells deadlock.
> >>
> >> Plenty people have shown they get this stuff.
> >
> >
> > Then I suggest that you can either take my patch to improve the
> > visual or remove the visual completely, as nobody cares about it.
> >
>
> I prefer the former. As Steven has mentioned elsewhere, people find
> lockdep output hard to follow (enough that he has given talks :) )
>
Not to mention. There's commit logs that throw everything out except
for this information. See commits:
692b48258dda
5acb3cc2c2e9
7b7622bb95eb5
478fe3037b227
fdaf0a51bad49
1ddd45f8d76f0
63aea0dbab90a
1215e51edad12
f159b3c7cd45c
And those only go back to March of this year.
-- Steve
next prev parent reply other threads:[~2017-12-19 17:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 17:38 Steven Rostedt
2017-12-14 17:59 ` Peter Zijlstra
2017-12-14 18:19 ` Steven Rostedt
2017-12-19 16:30 ` Dhaval Giani
2017-12-19 16:46 ` Peter Zijlstra
2017-12-19 16:52 ` Steven Rostedt
2017-12-19 16:54 ` Dhaval Giani
2017-12-19 17:10 ` Steven Rostedt [this message]
2017-12-19 17:07 ` Peter Zijlstra
2017-12-19 17:11 ` Steven Rostedt
2017-12-19 17:29 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219121010.06ad6a73@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=dhaval.giani@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®