From: Ingo Molnar <mingo@kernel.org>
To: Mike Travis <travis@sgi.com>
Cc: Ingo Molnar <mingo@redhat.com>, Russ Anderson <rja@hpe.com>,
Dimitri Sivanich <sivanich@hpe.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Andrew Banman <abanman@hpe.com>
Subject: Re: [PATCH 0/7] x86/platform/UV: UV Fix patches for Intel processors
Date: Thu, 21 Dec 2017 12:49:26 +0100 [thread overview]
Message-ID: <20171221114926.7drqdlszr2lu3gmm@gmail.com> (raw)
In-Reply-To: <1513812446-260956-1-git-send-email-travis@sgi.com>
* Mike Travis <travis@sgi.com> wrote:
>
> This patchset handles the fixes made to the UV4 HUB for upcoming Intel
> processors as there are some interface changes.
>
> * Update uv_mmrs.h to prep for fixed defines for UV4A.
>
> * Updates to handle UV4 vs. UV4A (fixed) arches.
>
> * Updates to handle UV4 GAM (global addressable memory) MMRs fixes.
>
> * Updates to handle UV4 BAU (broadcast assist unit) MMRs fixes.
>
> * Turn on UV4A_IS_SUPPORTED to enable code and header file fixes.
Sigh, has any of this been properly build tested? x86-64 allyesconfig produces a
bunch of ugly warnings:
In file included from ./include/linux/kernel.h:14:0,
arch/x86/kernel/apic/x2apic_uv_x.c: In function ‘map_mmioh_high_uv34’:
./include/linux/printk.h:308:2: warning: ‘id’ may be used uninitialized in this function [-Wmaybe-uninitialized]
arch/x86/kernel/apic/x2apic_uv_x.c:806:8: note: ‘id’ was declared here
In file included from ./include/linux/kernel.h:14:0,
./include/linux/printk.h:308:2: warning: ‘m_io’ may be used uninitialized in this function [-Wmaybe-uninitialized]
arch/x86/kernel/apic/x2apic_uv_x.c:804:19: note: ‘m_io’ was declared here
In file included from ./include/linux/kernel.h:14:0,
./include/linux/printk.h:308:2: warning: ‘shift’ may be used uninitialized in this function [-Wmaybe-uninitialized]
arch/x86/kernel/apic/x2apic_uv_x.c:804:12: note: ‘shift’ was declared here
arch/x86/kernel/apic/x2apic_uv_x.c:856:14: warning: ‘n’ may be used uninitialized in this function [-Wmaybe-uninitialized]
arch/x86/kernel/apic/x2apic_uv_x.c:846:9: warning: ‘nasid_mask’ may be used uninitialized in this function [-Wmaybe-uninitialized]
In file included from ./include/linux/kernel.h:14:0,
./include/linux/printk.h:308:2: warning: ‘base’ may be used uninitialized in this function [-Wmaybe-uninitialized]
arch/x86/kernel/apic/x2apic_uv_x.c:801:16: note: ‘base’ was declared here
arch/x86/kernel/apic/x2apic_uv_x.c:843:17: warning: ‘mmr’ may be used uninitialized in this function [-Wmaybe-uninitialized]
arch/x86/kernel/apic/x2apic_uv_x.c:832:16: warning: ‘overlay’ may be used uninitialized in this function [-Wmaybe-uninitialized]
Thanks,
Ingo
next prev parent reply other threads:[~2017-12-21 11:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 23:27 Mike Travis
2017-12-20 23:27 ` [PATCH 1/7] x86/platform/UV: Update uv_mmrs.h to prep for UV4A fixes Mike Travis
2017-12-20 23:27 ` [PATCH 2/7] x86/platform/UV: Support for UV4A fixes for new Intel Processors Mike Travis
2017-12-20 23:27 ` [PATCH 3/7] x86/platform/UV: Add references to access to fixed UV4A HUB MMRs Mike Travis
2017-12-20 23:27 ` [PATCH 4/7] x86/platform/UV: Fix GAM MMR changes in UV4A Mike Travis
2017-12-20 23:27 ` [PATCH 5/7] x86/platform/UV: Fix GAM MMR references in UV x2apic code Mike Travis
2017-12-20 23:27 ` [PATCH 6/7] x86/platform/UV: Fix for UV4A BAU MMRs Mike Travis
2017-12-20 23:30 ` [PATCH 7/7] x86/platform/uv/BAU: Fix broadcast descriptor base for UV4A Andrew Banman
2017-12-21 11:49 ` Ingo Molnar [this message]
2017-12-21 15:39 ` [PATCH 0/7] x86/platform/UV: UV Fix patches for Intel processors Mike Travis
2017-12-21 18:01 ` Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171221114926.7drqdlszr2lu3gmm@gmail.com \
--to=mingo@kernel.org \
--cc=abanman@hpe.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rja@hpe.com \
--cc=sivanich@hpe.com \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome