From: Mike Travis <mike.travis@hpe.com>
To: Ingo Molnar <mingo@kernel.org>, Mike Travis <travis@sgi.com>
Cc: Ingo Molnar <mingo@redhat.com>, Russ Anderson <rja@hpe.com>,
"Dimitri Sivanich" <sivanich@hpe.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>, <x86@kernel.org>,
<linux-kernel@vger.kernel.org>, Andrew Banman <abanman@hpe.com>
Subject: Re: [PATCH 0/7] x86/platform/UV: UV Fix patches for Intel processors
Date: Thu, 21 Dec 2017 10:01:48 -0800 [thread overview]
Message-ID: <25fc4af5-4f6f-3d68-9910-51707665cc27@hpe.com> (raw)
In-Reply-To: <618265fc-c053-e34e-7544-95cfd910dead@hpe.com>
On 12/21/2017 7:39 AM, Mike Travis wrote:
>> Sigh, has any of this been properly build tested? x86-64 allyesconfig
>> produces a
>> bunch of ugly warnings:
>
...
> I will try this "allyesconfig" though I believe it introduces CONFIG
> items that cause problems where the resultant kernel doesn't boot on a
> UV system. But if building is the only goal, then we can ignore them.
I found the error and it had already been fixed. But somehow during the
hand off for submission, an earlier version was included in this patch.
Unfortunately most everyone is out for a mandatory shutdown (I've been
working during my last 5 vacation days), so I'm not sure we can push the
entire patch set again until the new year.
Here's the small change that fixed these warnings that slipped out:
--- linux.orig/arch/x86/kernel/apic/x2apic_uv_x.c
+++ linux/arch/x86/kernel/apic/x2apic_uv_x.c
@@ -816,7 +816,7 @@ static __init void map_mmioh_high_uv34(i
shift = UVH_RH_GAM_MMIOH_OVERLAY_CONFIG0_MMR_M_IO_SHFT;
n = UVH_RH_GAM_MMIOH_REDIRECT_CONFIG0_MMR_DEPTH;
nasid_mask = UVH_RH_GAM_MMIOH_REDIRECT_CONFIG0_MMR_NASID_MASK;
- } else if (index == 1) {
+ } else {
id = "MMIOH1";
m_overlay = UVH_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR;
overlay = uv_read_local_mmr(m_overlay);
Would it be possible for you to insert this after...
[PATCH 4/7] x86/platform/UV: Fix GAM MMR changes in UV4A
??
Thanks,
Mike
prev parent reply other threads:[~2017-12-21 18:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 23:27 Mike Travis
2017-12-20 23:27 ` [PATCH 1/7] x86/platform/UV: Update uv_mmrs.h to prep for UV4A fixes Mike Travis
2017-12-20 23:27 ` [PATCH 2/7] x86/platform/UV: Support for UV4A fixes for new Intel Processors Mike Travis
2017-12-20 23:27 ` [PATCH 3/7] x86/platform/UV: Add references to access to fixed UV4A HUB MMRs Mike Travis
2017-12-20 23:27 ` [PATCH 4/7] x86/platform/UV: Fix GAM MMR changes in UV4A Mike Travis
2017-12-20 23:27 ` [PATCH 5/7] x86/platform/UV: Fix GAM MMR references in UV x2apic code Mike Travis
2017-12-20 23:27 ` [PATCH 6/7] x86/platform/UV: Fix for UV4A BAU MMRs Mike Travis
2017-12-20 23:30 ` [PATCH 7/7] x86/platform/uv/BAU: Fix broadcast descriptor base for UV4A Andrew Banman
2017-12-21 11:49 ` [PATCH 0/7] x86/platform/UV: UV Fix patches for Intel processors Ingo Molnar
2017-12-21 15:39 ` Mike Travis
2017-12-21 18:01 ` Mike Travis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25fc4af5-4f6f-3d68-9910-51707665cc27@hpe.com \
--to=mike.travis@hpe.com \
--cc=abanman@hpe.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=rja@hpe.com \
--cc=sivanich@hpe.com \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®