[PATCH] staging: irda: net: Fix warning for incomplete Declarations in irlap.c

[PATCH] staging: irda: net: Fix warning for incomplete Declarations in irlap.c

[Vaibhav Kothari]

This patch fixes the Sparse Warning "symbol was
not declared. Should it be static?" in net/irlap.c

Signed-off-by: Vaibhav Kothari <vaibhavddit@gmail.com>
---
 drivers/staging/irda/net/irlap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/irda/net/irlap.c b/drivers/staging/irda/net/irlap.c
index d7d8944..6bc5f0b5 100644
--- a/drivers/staging/irda/net/irlap.c
+++ b/drivers/staging/irda/net/irlap.c
@@ -48,12 +48,12 @@
 #include <net/irda/qos.h>
 
 static hashbin_t *irlap = NULL;
-int sysctl_slot_timeout = SLOT_TIMEOUT * 1000 / HZ;
+static int sysctl_slot_timeout = SLOT_TIMEOUT * 1000 / HZ;
 
 /* This is the delay of missed pf period before generating an event
  * to the application. The spec mandate 3 seconds, but in some cases
  * it's way too long. - Jean II */
-int sysctl_warn_noreply_time = 3;
+static int sysctl_warn_noreply_time = 3;
 
 extern void irlap_queue_xmit(struct irlap_cb *self, struct sk_buff *skb);
 static void __irlap_close(struct irlap_cb *self);
-- 
2.7.4

Re: [PATCH] staging: irda: net: Fix warning for incomplete Declarations in irlap.c

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 973 bytes --]

Hi Vaibhav,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.15-rc5 next-20171222]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Vaibhav-Kothari/staging-irda-net-Fix-warning-for-incomplete-Declarations-in-irlap-c/20171230-023604
config: i386-randconfig-s1-201752 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

>> ERROR: "sysctl_slot_timeout" [drivers/staging/irda/net/irda.ko] undefined!
>> ERROR: "sysctl_warn_noreply_time" [drivers/staging/irda/net/irda.ko] undefined!

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28304 bytes --]

Re: [PATCH] staging: irda: net: Fix warning for incomplete Declarations in irlap.c

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]

Hi Vaibhav,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.15-rc5 next-20171222]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Vaibhav-Kothari/staging-irda-net-Fix-warning-for-incomplete-Declarations-in-irlap-c/20171230-023604
config: x86_64-allyesdebian (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/staging/irda/net/timer.o: In function `irlap_start_query_timer':
   timer.c:(.text+0xcb): undefined reference to `sysctl_slot_timeout'
>> drivers/staging/irda/net/irsysctl.o:(.data+0x148): undefined reference to `sysctl_slot_timeout'
>> drivers/staging/irda/net/irsysctl.o:(.data+0x2c8): undefined reference to `sysctl_warn_noreply_time'

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39849 bytes --]