From: Valdis.Kletnieks@vt.edu
To: Helge Deller <deller@gmx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC] Time-based RFC 4122 UUID generator
Date: Sun, 07 Oct 2007 10:02:56 -0400 [thread overview]
Message-ID: <2018.1191765776@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Sun, 07 Oct 2007 12:08:10 +0200." <200710071208.11030.deller@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]
On Sun, 07 Oct 2007 12:08:10 +0200, you said:
> Thanks that you ask!
> I really should have mentioned it in my initial posting.
>
> Yes, this change was intentional, as it in fact fixes a possible bug in the original code.
> Section 4.1.6 in RFC 4122 states regarding the "NodeID":
> : For systems with no IEEE address, a randomly or pseudo-randomly
> : generated value may be used; see Section 4.5. The multicast bit must
> : be set in such addresses, in order that they will never conflict with
> : addresses obtained from network cards.
>
> So up to now it was just pure ("random") luck if this bit was set or not.
Sounds like a valid bugfix then - but it should probably be sent upstream
separately, with it's own changelog (what I quoted above should be fine)...
Remember - one patch, one logical change, so your patch should be split up
(among other things, that way the bugfix can proceed even if the new-function
part gets hung up in review).....
Other than splitting it up, I have no further comments on either part.. Enjoy...
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
prev parent reply other threads:[~2007-10-07 14:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-06 13:53 Helge Deller
2007-10-07 3:42 ` Valdis.Kletnieks
2007-10-07 10:08 ` Helge Deller
2007-10-07 14:02 ` Valdis.Kletnieks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2018.1191765776@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome