From: Valdis.Kletnieks@vt.edu
To: Helge Deller <deller@gmx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC] Time-based RFC 4122 UUID generator
Date: Sat, 06 Oct 2007 23:42:10 -0400 [thread overview]
Message-ID: <20668.1191728530@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Sat, 06 Oct 2007 15:53:37 +0200." <200710061553.37311.deller@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
On Sat, 06 Oct 2007 15:53:37 +0200, Helge Deller said:
> diff --git a/drivers/char/random.c b/drivers/char/random.c
> index af274e5..c84a385 100644
> --- a/drivers/char/random.c
> +++ b/drivers/char/random.c
> @@ -239,6 +239,7 @@
> #include <linux/spinlock.h>
> #include <linux/percpu.h>
> #include <linux/cryptohash.h>
> +#include <linux/netdevice.h>
>
> #include <asm/processor.h>
> #include <asm/uaccess.h>
> @@ -1157,6 +1158,8 @@ void generate_random_uuid(unsigned char uuid_out[16])
> uuid_out[6] = (uuid_out[6] & 0x0F) | 0x40;
> /* Set the UUID variant to DCE */
> uuid_out[8] = (uuid_out[8] & 0x3F) | 0x80;
> + /* Set multicast bit to avoid conflicts with NIC MAC addresses */
> + uuid_out[10] |= 0x80;
> }
Erm, was it *intended* that you also changed the behavior of generate_random_uuid()?
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
next prev parent reply other threads:[~2007-10-07 3:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-06 13:53 Helge Deller
2007-10-07 3:42 ` Valdis.Kletnieks [this message]
2007-10-07 10:08 ` Helge Deller
2007-10-07 14:02 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20668.1191728530@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome