mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ARM: sunxi_defconfig: Enable SUNXI_CCU
@ 2018-01-01 19:22 Corentin Labbe
  2018-01-02  1:54 ` Chen-Yu Tsai
  0 siblings, 1 reply; 2+ messages in thread
From: Corentin Labbe @ 2018-01-01 19:22 UTC (permalink / raw)
  To: linux, maxime.ripard, wens
  Cc: linux-arm-kernel, linux-kernel, linux-sunxi, Corentin Labbe

While looking for missing symbol by diffing sunxi_defconfig and my
.config, I just found that no CLK symbol are present in sunxi_defconfig.

This patch add the missing CONFIG_SUNXI_CCU in sunxi_defconfig.
All other symbol will be automatically selected via their default value.

Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
 arch/arm/configs/sunxi_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/sunxi_defconfig b/arch/arm/configs/sunxi_defconfig
index 5caaf971fb50..5ed920e75842 100644
--- a/arch/arm/configs/sunxi_defconfig
+++ b/arch/arm/configs/sunxi_defconfig
@@ -16,6 +16,7 @@ CONFIG_CPU_FREQ=y
 CONFIG_CPUFREQ_DT=y
 CONFIG_VFP=y
 CONFIG_NEON=y
+CONFIG_SUNXI_CCU=y
 CONFIG_NET=y
 CONFIG_PACKET=y
 CONFIG_UNIX=y
-- 
2.13.6

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: sunxi_defconfig: Enable SUNXI_CCU
  2018-01-01 19:22 [PATCH] ARM: sunxi_defconfig: Enable SUNXI_CCU Corentin Labbe
@ 2018-01-02  1:54 ` Chen-Yu Tsai
  0 siblings, 0 replies; 2+ messages in thread
From: Chen-Yu Tsai @ 2018-01-02  1:54 UTC (permalink / raw)
  To: Corentin Labbe
  Cc: Russell King, Maxime Ripard, Chen-Yu Tsai, linux-arm-kernel,
	linux-kernel, linux-sunxi

On Tue, Jan 2, 2018 at 3:22 AM, Corentin Labbe
<clabbe.montjoie@gmail.com> wrote:
> While looking for missing symbol by diffing sunxi_defconfig and my
> .config, I just found that no CLK symbol are present in sunxi_defconfig.

This does not take into account default values in Kconfig. Use
`make savedefconfg` then compare the resulting defconfig file.

>
> This patch add the missing CONFIG_SUNXI_CCU in sunxi_defconfig.
> All other symbol will be automatically selected via their default value.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
>  arch/arm/configs/sunxi_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/sunxi_defconfig b/arch/arm/configs/sunxi_defconfig
> index 5caaf971fb50..5ed920e75842 100644
> --- a/arch/arm/configs/sunxi_defconfig
> +++ b/arch/arm/configs/sunxi_defconfig
> @@ -16,6 +16,7 @@ CONFIG_CPU_FREQ=y
>  CONFIG_CPUFREQ_DT=y
>  CONFIG_VFP=y
>  CONFIG_NEON=y
> +CONFIG_SUNXI_CCU=y

Not needed. See the last line of:

config SUNXI_CCU
        bool "Clock support for Allwinner SoCs"
        depends on ARCH_SUNXI || COMPILE_TEST
        select RESET_CONTROLLER
        default ARCH_SUNXI

Surely kernelci hasn't been broken since the introduction of
sunxi-ng. :)

ChenYu

>  CONFIG_NET=y
>  CONFIG_PACKET=y
>  CONFIG_UNIX=y
> --
> 2.13.6
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-02  1:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-01 19:22 [PATCH] ARM: sunxi_defconfig: Enable SUNXI_CCU Corentin Labbe
2018-01-02  1:54 ` Chen-Yu Tsai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®