* [PATCH] Bluetooth: hciuart: add nvmem dependency
@ 2018-01-02 10:50 Arnd Bergmann
2018-01-02 11:18 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-01-02 10:50 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg
Cc: David Lechner, Arnd Bergmann, Sebastian Reichel, Hans de Goede,
Bjorn Andersson, Tobias Regnery, linux-bluetooth, linux-kernel
When the hci support is built-in, but mvmem is a loadable module, we
get a link failure:
drivers/bluetooth/hci_ll.o: In function `hci_ti_probe':
hci_ll.c:(.text+0x226): undefined reference to `nvmem_cell_get'
hci_ll.c:(.text+0x238): undefined reference to `nvmem_cell_read'
hci_ll.c:(.text+0x244): undefined reference to `nvmem_cell_put'
This adds another Kconfig dependency to enforce valid configurations.
Fixes: 0e58d0cdb3eb ("Bluetooth: hci_ll: Add optional nvmem BD address source")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/bluetooth/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index 41932f0e68d0..d816ce9e23a7 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -77,6 +77,7 @@ config BT_HCIBTSDIO
config BT_HCIUART
tristate "HCI UART driver"
depends on SERIAL_DEV_BUS || !SERIAL_DEV_BUS
+ depends on NVMEM || !NVMEM
depends on TTY
help
Bluetooth HCI UART driver.
--
2.9.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Bluetooth: hciuart: add nvmem dependency
2018-01-02 10:50 [PATCH] Bluetooth: hciuart: add nvmem dependency Arnd Bergmann
@ 2018-01-02 11:18 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2018-01-02 11:18 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Johan Hedberg, David Lechner, Sebastian Reichel, Hans de Goede,
Bjorn Andersson, Tobias Regnery, linux-bluetooth, linux-kernel
Hi Arnd,
> When the hci support is built-in, but mvmem is a loadable module, we
> get a link failure:
>
> drivers/bluetooth/hci_ll.o: In function `hci_ti_probe':
> hci_ll.c:(.text+0x226): undefined reference to `nvmem_cell_get'
> hci_ll.c:(.text+0x238): undefined reference to `nvmem_cell_read'
> hci_ll.c:(.text+0x244): undefined reference to `nvmem_cell_put'
>
> This adds another Kconfig dependency to enforce valid configurations.
>
> Fixes: 0e58d0cdb3eb ("Bluetooth: hci_ll: Add optional nvmem BD address source")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/bluetooth/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-02 11:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-02 10:50 [PATCH] Bluetooth: hciuart: add nvmem dependency Arnd Bergmann
2018-01-02 11:18 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®