Re: [PATCH] ext4: fix incorrect indentation of if statement

[Jan Kara <jack@suse.cz>]

On Wed 29-11-17 14:20:59, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The indentation is incorrect and spaces need replacing with a tab
> on the if statement.
> 
> Cleans up smatch warning:
> fs/ext4/namei.c:3220 ext4_link() warn: inconsistent indenting
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

This seems to fall through cracks. The patch looks good. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza


> ---
>  fs/ext4/namei.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index 798b3ac680db..d3fabc553c65 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -3217,8 +3217,8 @@ static int ext4_link(struct dentry *old_dentry,
>  	if (err)
>  		return err;
>  
> -       if ((ext4_test_inode_flag(dir, EXT4_INODE_PROJINHERIT)) &&
> -	   (!projid_eq(EXT4_I(dir)->i_projid,
> +	if ((ext4_test_inode_flag(dir, EXT4_INODE_PROJINHERIT)) &&
> +	    (!projid_eq(EXT4_I(dir)->i_projid,
>  		       EXT4_I(old_dentry->d_inode)->i_projid)))
>  		return -EXDEV;
>  
> -- 
> 2.14.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR