From: Mark Brown <broonie@kernel.org>
To: Steven Eckhoff <steven.eckhoff.opensource@gmail.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org,
Philippe Ombredanne <pombredanne@nexb.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>
Subject: Re: [alsa-devel][PATCH v7] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC
Date: Fri, 5 Jan 2018 12:22:42 +0000 [thread overview]
Message-ID: <20180105122242.GC9076@sirena.org.uk> (raw)
In-Reply-To: <20171219205415.wlu4atv2mdy7i3gb@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]
On Tue, Dec 19, 2017 at 02:54:25PM -0600, Steven Eckhoff wrote:
> + SOC_ENUM("MBC Band1 Level Detect Switch",
> + mbc_level_detection_enums[0]),
> + SOC_ENUM("MBC Band2 Level Detect Switch",
> + mbc_level_detection_enums[1]),
> + SOC_ENUM("MBC Band3 Level Detect Switch",
> + mbc_level_detection_enums[2]),
> + SOC_ENUM("MBC Band1 Level Detect Win Switch",
> + mbc_level_detection_window_enums[0]),
> + SOC_ENUM("MBC Band2 Level Detect Win Switch",
> + mbc_level_detection_window_enums[1]),
> + SOC_ENUM("MBC Band3 Level Detect Win Switch",
> + mbc_level_detection_window_enums[2]),
These are enums so they should probably not have Switch at the end of
their name, I suspect that might confuse userspace somehow.
> + SOC_SINGLE("MBC1 Phase Invert", R_DACMBCMUG1, FB_DACMBCMUG1_PHASE,
> + 1, 0),
While this is an on/off switch (for inversion) so it ought to end in
Switch. Otherwise this driver looks good I think, just those couple of
small things so I'll apply - please send followup patches fixing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-01-05 12:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 20:54 Steven Eckhoff
2018-01-05 12:22 ` Mark Brown [this message]
2018-01-06 17:00 ` Steven Eckhoff
2018-01-05 12:38 ` Mark Brown
2018-01-07 12:57 ` Steven Eckhoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180105122242.GC9076@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pombredanne@nexb.com \
--cc=steven.eckhoff.opensource@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®