From: Dan Carpenter <dan.carpenter@oracle.com>
To: Luis Gerhorst <linux-kernel@luisgerhorst.de>
Cc: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
"Jonny Schäfer" <schaefer.jonny@gmail.com>,
linux-kernel@i4.cs.fau.de
Subject: Re: [PATCH 2/3] drivers/fbtft: Remove unnecessary braces from if/else
Date: Mon, 8 Jan 2018 18:03:39 +0300 [thread overview]
Message-ID: <20180108150339.3jstz64fbawef45i@mwanda> (raw)
In-Reply-To: <1515405997-12563-1-git-send-email-linux-kernel@luisgerhorst.de>
On Mon, Jan 08, 2018 at 11:06:37AM +0100, Luis Gerhorst wrote:
> The Linux kernel coding style states that braces should only be used
> when necessary.
>
> This fixes the checkpatch warning
>
> WARNING: line over 80 characters
> + } else if (display->regwidth == 8 && display->buswidth == 9 && par->spi) {
>
> introduced by patch #1.
>
Don't introduce warnings and then fix them in later patches.
Anyway there is another unwritten rule that multi-line indents get curly
braces. Probably it should be:
} else if (display->regwidth == 8 && display->buswidth == 9 &&
par->spi) {
regards,
dan carpenter
next prev parent reply other threads:[~2018-01-08 15:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 10:06 Luis Gerhorst
2018-01-08 15:03 ` Dan Carpenter [this message]
2018-01-08 18:27 ` Joe Perches
2018-01-08 19:26 ` Dan Carpenter
2018-01-08 19:48 ` Joe Perches
2018-01-08 20:35 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108150339.3jstz64fbawef45i@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@luisgerhorst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=schaefer.jonny@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®