* [PATCH] media: mtk-vcodec: Always signal source change event on format change
@ 2018-01-09 8:42 Tomasz Figa
2018-01-09 8:51 ` Wu-Cheng Li (李務誠)
0 siblings, 1 reply; 2+ messages in thread
From: Tomasz Figa @ 2018-01-09 8:42 UTC (permalink / raw)
To: linux-media
Cc: Tiffany Lin, Andrew-CT Chen, Mauro Carvalho Chehab,
Matthias Brugger, linux-arm-kernel, linux-mediatek, linux-kernel,
Paweł Ościak, Wu-Cheng Li, Tomasz Figa
Currently the driver signals the source change event only in case of
a midstream resolution change, however the initial format detection
is also defined as a source change by the V4L2 codec API specification.
Fix this by signaling the event after the initial header is parsed as
well.
Signed-off-by: Tomasz Figa <tfiga@chromium.org>
---
drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
index 843510979ad8..86f0a7134365 100644
--- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
+++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
@@ -1224,6 +1224,8 @@ static void vb2ops_vdec_buf_queue(struct vb2_buffer *vb)
ctx->dpb_size = dpbsize;
ctx->state = MTK_STATE_HEADER;
mtk_v4l2_debug(1, "[%d] dpbsize=%d", ctx->id, ctx->dpb_size);
+
+ mtk_vdec_queue_res_chg_event(ctx);
}
static void vb2ops_vdec_buf_finish(struct vb2_buffer *vb)
--
2.16.0.rc0.223.g4a4ac83678-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] media: mtk-vcodec: Always signal source change event on format change
2018-01-09 8:42 [PATCH] media: mtk-vcodec: Always signal source change event on format change Tomasz Figa
@ 2018-01-09 8:51 ` Wu-Cheng Li (李務誠)
0 siblings, 0 replies; 2+ messages in thread
From: Wu-Cheng Li (李務誠) @ 2018-01-09 8:51 UTC (permalink / raw)
To: Tomasz Figa
Cc: linux-media, Tiffany Lin, Andrew-CT Chen, Mauro Carvalho Chehab,
Matthias Brugger, linux-arm-kernel, linux-mediatek, linux-kernel,
Paweł Ościak, Wu-Cheng Li
Reviewed-by: Wu-Cheng Li <wuchengli@chromium.org>
On Tue, Jan 9, 2018 at 4:42 PM, Tomasz Figa <tfiga@chromium.org> wrote:
> Currently the driver signals the source change event only in case of
> a midstream resolution change, however the initial format detection
> is also defined as a source change by the V4L2 codec API specification.
> Fix this by signaling the event after the initial header is parsed as
> well.
>
> Signed-off-by: Tomasz Figa <tfiga@chromium.org>
> ---
> drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
> index 843510979ad8..86f0a7134365 100644
> --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
> +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
> @@ -1224,6 +1224,8 @@ static void vb2ops_vdec_buf_queue(struct vb2_buffer *vb)
> ctx->dpb_size = dpbsize;
> ctx->state = MTK_STATE_HEADER;
> mtk_v4l2_debug(1, "[%d] dpbsize=%d", ctx->id, ctx->dpb_size);
> +
> + mtk_vdec_queue_res_chg_event(ctx);
> }
>
> static void vb2ops_vdec_buf_finish(struct vb2_buffer *vb)
> --
> 2.16.0.rc0.223.g4a4ac83678-goog
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-09 8:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-09 8:42 [PATCH] media: mtk-vcodec: Always signal source change event on format change Tomasz Figa
2018-01-09 8:51 ` Wu-Cheng Li (李務誠)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®