* [PATCH] [net-next] net: socionext: include linux/io.h to fix build
@ 2018-01-11 10:36 Arnd Bergmann
2018-01-11 10:38 ` Ard Biesheuvel
2018-01-11 18:54 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2018-01-11 10:36 UTC (permalink / raw)
To: David S . Miller, Jassi Brar
Cc: Arnd Bergmann, Ard Biesheuvel, netdev, linux-kernel
I ran into a randconfig build failure:
drivers/net/ethernet/socionext/netsec.c: In function 'netsec_probe':
drivers/net/ethernet/socionext/netsec.c:1583:17: error: implicit declaration of function 'devm_ioremap'; did you mean 'ioremap'? [-Werror=implicit-function-declaration]
Including linux/io.h directly fixes this.
Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/socionext/netsec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
index a8edcf387bba..af47147dd656 100644
--- a/drivers/net/ethernet/socionext/netsec.c
+++ b/drivers/net/ethernet/socionext/netsec.c
@@ -8,6 +8,7 @@
#include <linux/of_mdio.h>
#include <linux/etherdevice.h>
#include <linux/interrupt.h>
+#include <linux/io.h>
#include <net/tcp.h>
#include <net/ip6_checksum.h>
--
2.9.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [net-next] net: socionext: include linux/io.h to fix build
2018-01-11 10:36 [PATCH] [net-next] net: socionext: include linux/io.h to fix build Arnd Bergmann
@ 2018-01-11 10:38 ` Ard Biesheuvel
2018-01-11 18:54 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2018-01-11 10:38 UTC (permalink / raw)
To: Arnd Bergmann
Cc: David S . Miller, Jassi Brar, <netdev@vger.kernel.org>,
Linux Kernel Mailing List
On 11 January 2018 at 10:36, Arnd Bergmann <arnd@arndb.de> wrote:
> I ran into a randconfig build failure:
>
> drivers/net/ethernet/socionext/netsec.c: In function 'netsec_probe':
> drivers/net/ethernet/socionext/netsec.c:1583:17: error: implicit declaration of function 'devm_ioremap'; did you mean 'ioremap'? [-Werror=implicit-function-declaration]
>
> Including linux/io.h directly fixes this.
>
> Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for fixing this. This is the same issue spotted by kbuild test robot.
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> drivers/net/ethernet/socionext/netsec.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
> index a8edcf387bba..af47147dd656 100644
> --- a/drivers/net/ethernet/socionext/netsec.c
> +++ b/drivers/net/ethernet/socionext/netsec.c
> @@ -8,6 +8,7 @@
> #include <linux/of_mdio.h>
> #include <linux/etherdevice.h>
> #include <linux/interrupt.h>
> +#include <linux/io.h>
>
> #include <net/tcp.h>
> #include <net/ip6_checksum.h>
> --
> 2.9.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [net-next] net: socionext: include linux/io.h to fix build
2018-01-11 10:36 [PATCH] [net-next] net: socionext: include linux/io.h to fix build Arnd Bergmann
2018-01-11 10:38 ` Ard Biesheuvel
@ 2018-01-11 18:54 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-01-11 18:54 UTC (permalink / raw)
To: arnd; +Cc: jaswinder.singh, ard.biesheuvel, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 11 Jan 2018 11:36:24 +0100
> I ran into a randconfig build failure:
>
> drivers/net/ethernet/socionext/netsec.c: In function 'netsec_probe':
> drivers/net/ethernet/socionext/netsec.c:1583:17: error: implicit declaration of function 'devm_ioremap'; did you mean 'ioremap'? [-Werror=implicit-function-declaration]
>
> Including linux/io.h directly fixes this.
>
> Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-11 18:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-11 10:36 [PATCH] [net-next] net: socionext: include linux/io.h to fix build Arnd Bergmann
2018-01-11 10:38 ` Ard Biesheuvel
2018-01-11 18:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®