From: David Miller <davem@davemloft.net>
To: dima@arista.com
Cc: linux-kernel@vger.kernel.org, 0x7f454c46@gmail.com,
arnd@arndb.de, dwindsor@gmail.com, edumazet@google.com,
mingo@kernel.org, johannes.berg@intel.com, mark.rutland@arm.com,
rrendec@arista.com, elena.reshetova@intel.com,
netdev@vger.kernel.org
Subject: Re: [PATCH 3/5] pktgen: Add behavior flag names array - pkt_flag_names
Date: Mon, 15 Jan 2018 13:09:36 -0500 (EST) [thread overview]
Message-ID: <20180115.130936.1345693036896474880.davem@davemloft.net> (raw)
In-Reply-To: <20180109135535.15237-4-dima@arista.com>
From: Dmitry Safonov <dima@arista.com>
Date: Tue, 9 Jan 2018 13:55:33 +0000
> +#define pf(flag) __stringify(flag),
> +char *pkt_flag_names[] = {
> + PKT_FLAGS
> +};
> +#undef pf
This should be static, also you don't use this table in this patch. You
should add the table in the patch that actually uses the table.
next prev parent reply other threads:[~2018-01-15 18:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 13:55 [PATCH 0/5] pktgen: Behavior flags fixes Dmitry Safonov
2018-01-09 13:55 ` [PATCH 1/5] Documentation/pktgen: Clearify how-to use pktgen samples Dmitry Safonov
2018-01-09 13:55 ` [PATCH 2/5] pktgen: Add missing !flag parameters Dmitry Safonov
2018-01-09 13:55 ` [PATCH 3/5] pktgen: Add behavior flag names array - pkt_flag_names Dmitry Safonov
2018-01-15 18:09 ` David Miller [this message]
2018-01-15 18:13 ` Dmitry Safonov
2018-01-09 13:55 ` [PATCH 4/5] pktgen: Remove brute-force printing of flags Dmitry Safonov
2018-01-09 13:55 ` [PATCH 5/5] pktgen: Clean read user supplied flag mess Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115.130936.1345693036896474880.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=0x7f454c46@gmail.com \
--cc=arnd@arndb.de \
--cc=dima@arista.com \
--cc=dwindsor@gmail.com \
--cc=edumazet@google.com \
--cc=elena.reshetova@intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rrendec@arista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®