* [PATCH] watchdog: rave-sp: add NVMEM dependency
@ 2018-01-15 16:10 Arnd Bergmann
2018-01-15 18:00 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-01-15 16:10 UTC (permalink / raw)
To: Lee Jones
Cc: Pavel Machek, Guenter Roeck, Nikita Yushchenko, Andrey Smirnov,
Arnd Bergmann, Wim Van Sebroeck, linux-watchdog, linux-kernel
We can build this driver with or without NVMEM, but not built-in
when NVMEM is a loadable module:
drivers/watchdog/rave-sp-wdt.o: In function `rave_sp_wdt_probe':
rave-sp-wdt.c:(.text+0x27c): undefined reference to `nvmem_cell_get'
rave-sp-wdt.c:(.text+0x290): undefined reference to `nvmem_cell_read'
rave-sp-wdt.c:(.text+0x2c4): undefined reference to `nvmem_cell_put'
This adds a Kconfig dependency to enforce that.
Fixes: c3bb33345721 ("watchdog: Add RAVE SP watchdog driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/watchdog/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 34d1c6851fa7..c09369f80989 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -226,6 +226,7 @@ config ZIIRAVE_WATCHDOG
config RAVE_SP_WATCHDOG
tristate "RAVE SP Watchdog timer"
depends on RAVE_SP_CORE
+ depends on NVMEM || !NVMEM
select WATCHDOG_CORE
help
Support for the watchdog on RAVE SP device.
--
2.9.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] watchdog: rave-sp: add NVMEM dependency
2018-01-15 16:10 [PATCH] watchdog: rave-sp: add NVMEM dependency Arnd Bergmann
@ 2018-01-15 18:00 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2018-01-15 18:00 UTC (permalink / raw)
To: Arnd Bergmann, Lee Jones
Cc: Pavel Machek, Nikita Yushchenko, Andrey Smirnov,
Wim Van Sebroeck, linux-watchdog, linux-kernel
On 01/15/2018 08:10 AM, Arnd Bergmann wrote:
> We can build this driver with or without NVMEM, but not built-in
> when NVMEM is a loadable module:
>
> drivers/watchdog/rave-sp-wdt.o: In function `rave_sp_wdt_probe':
> rave-sp-wdt.c:(.text+0x27c): undefined reference to `nvmem_cell_get'
> rave-sp-wdt.c:(.text+0x290): undefined reference to `nvmem_cell_read'
> rave-sp-wdt.c:(.text+0x2c4): undefined reference to `nvmem_cell_put'
>
> This adds a Kconfig dependency to enforce that.
>
> Fixes: c3bb33345721 ("watchdog: Add RAVE SP watchdog driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 34d1c6851fa7..c09369f80989 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -226,6 +226,7 @@ config ZIIRAVE_WATCHDOG
> config RAVE_SP_WATCHDOG
> tristate "RAVE SP Watchdog timer"
> depends on RAVE_SP_CORE
> + depends on NVMEM || !NVMEM
> select WATCHDOG_CORE
> help
> Support for the watchdog on RAVE SP device.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-15 18:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-15 16:10 [PATCH] watchdog: rave-sp: add NVMEM dependency Arnd Bergmann
2018-01-15 18:00 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®