From: Steven Rostedt <rostedt@goodmis.org>
To: Paul Menzel <pmenzel+linux-ftrace@molgen.mpg.de>
Cc: Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, regression@leemhuis.info,
Mario Limonciello <mario.limonciello@dell.com>,
Len Brown <len.brown@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: Suspend/resume with FTRACE enabled doesn’t work anymore
Date: Wed, 17 Jan 2018 11:25:56 -0500 [thread overview]
Message-ID: <20180117112556.7bc7fe0f@gandalf.local.home> (raw)
In-Reply-To: <20180117111943.75cac2dd@gandalf.local.home>
On Wed, 17 Jan 2018 11:19:43 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Wed, 17 Jan 2018 11:10:31 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
>
> > It's been fixed, and the the patch is in Linus's tree already:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a0e3a18f4baf8e3754ac1e56f0ade924d0c0c721
>
> Although I just noticed that the revert, also reverted the required
> barriers. I'll go add them back in.
>
I take that back. Barriers are not needed, as interrupts do not need to
see the updates. And looking at the patch being reverted, I don't think
they were needed there either. The update to those bits only need to be
done for the current context to prevent recursion at that context. And
that was the case with the commit that was reverted.
-- Steve
next prev parent reply other threads:[~2018-01-17 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 14:20 Paul Menzel
2018-01-17 15:19 ` Paul Menzel
2018-01-17 16:10 ` Steven Rostedt
2018-01-17 16:19 ` Steven Rostedt
2018-01-17 16:25 ` Steven Rostedt [this message]
2018-01-18 9:33 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117112556.7bc7fe0f@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=mingo@kernel.org \
--cc=pmenzel+linux-ftrace@molgen.mpg.de \
--cc=rafael.j.wysocki@intel.com \
--cc=regression@leemhuis.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®