* [PATCH] iommu/omap: Fix debugfs_create_*() usage
@ 2018-01-02 15:29 Geert Uytterhoeven
2018-01-17 13:23 ` Joerg Roedel
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2018-01-02 15:29 UTC (permalink / raw)
To: Joerg Roedel, iommu, Tony Lindgren
Cc: linux-omap, linux-kernel, Geert Uytterhoeven
When exposing data access through debugfs, the correct
debugfs_create_*() functions must be used, depending on data type.
Remove all casts from data pointers passed to debugfs_create_*()
functions, as such casts prevent the compiler from flagging bugs.
omap_iommu.nr_tlb_entries is "int", hence casting to "u8 *" exposes only
a part of it. Fix this by using debugfs_create_u32() instead.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Compile-tested only.
---
drivers/iommu/omap-iommu-debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iommu/omap-iommu-debug.c b/drivers/iommu/omap-iommu-debug.c
index 505548aafeff2276..50217548c3b8e7af 100644
--- a/drivers/iommu/omap-iommu-debug.c
+++ b/drivers/iommu/omap-iommu-debug.c
@@ -274,8 +274,8 @@ void omap_iommu_debugfs_add(struct omap_iommu *obj)
if (!obj->debug_dir)
return;
- d = debugfs_create_u8("nr_tlb_entries", 0400, obj->debug_dir,
- (u8 *)&obj->nr_tlb_entries);
+ d = debugfs_create_u32("nr_tlb_entries", 0400, obj->debug_dir,
+ &obj->nr_tlb_entries);
if (!d)
return;
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] iommu/omap: Fix debugfs_create_*() usage
2018-01-02 15:29 [PATCH] iommu/omap: Fix debugfs_create_*() usage Geert Uytterhoeven
@ 2018-01-17 13:23 ` Joerg Roedel
0 siblings, 0 replies; 2+ messages in thread
From: Joerg Roedel @ 2018-01-17 13:23 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: iommu, Tony Lindgren, linux-omap, linux-kernel
On Tue, Jan 02, 2018 at 04:29:45PM +0100, Geert Uytterhoeven wrote:
> When exposing data access through debugfs, the correct
> debugfs_create_*() functions must be used, depending on data type.
>
> Remove all casts from data pointers passed to debugfs_create_*()
> functions, as such casts prevent the compiler from flagging bugs.
>
> omap_iommu.nr_tlb_entries is "int", hence casting to "u8 *" exposes only
> a part of it. Fix this by using debugfs_create_u32() instead.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Compile-tested only.
> ---
> drivers/iommu/omap-iommu-debug.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-17 13:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-02 15:29 [PATCH] iommu/omap: Fix debugfs_create_*() usage Geert Uytterhoeven
2018-01-17 13:23 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®