mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: hayeswang@realtek.com
Cc: kai.heng.feng@canonical.com, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, mario.limonciello@dell.com,
	nic_swsd@realtek.com
Subject: Re: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock
Date: Thu, 18 Jan 2018 09:50:22 -0500 (EST)	[thread overview]
Message-ID: <20180118.095022.1121845945987753430.davem@davemloft.net> (raw)
In-Reply-To: <0835B3720019904CB8F7AA43166CEEB2D2E16D63@RTITMBSV06.realtek.com.tw>

From: Hayes Wang <hayeswang@realtek.com>
Date: Thu, 18 Jan 2018 03:04:08 +0000

> [...]
>> > r8153 on Dell TB15/16 dock corrupts rx packets.
>> >
>> > This change is suggested by Realtek. They guess that the XHCI
>> > controller doesn't have enough buffer, and their guesswork is correct,
>> > once the RX aggregation gets disabled, the issue is gone.
>> >
>> > ASMedia is currently working on a real sulotion for this issue.
>> >
>> > Dell and ODM confirm the bcdDevice and iSerialNumber is unique for TB16.
>> >
>> > Note that TB15 has different bcdDevice and iSerialNumber, which are
>> > not unique values. If you still have TB15, please contact Dell to
>> > replace it with TB16.
> 
> Excuse me. I don't understand why this patch is for specific USB nic rather than xHCI.
> It seems to make the specific USB nic working and the other ones keeping error.

Well, are we sure that the device being in the TB16 dock doesn't
contribute to the issue as well?

If the problem only shows up with XHCI and this dock, then this patch
was the appropriate way to deal with the problem for now.

  parent reply	other threads:[~2018-01-18 14:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-16  8:46 Kai-Heng Feng
2018-01-17 20:39 ` David Miller
2018-01-18  3:04   ` Hayes Wang
2018-01-18  3:38     ` Kai Heng Feng
2018-01-18 14:50     ` David Miller [this message]
2018-01-18 16:57       ` Kai Heng Feng
2018-01-18 17:06         ` Mario.Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180118.095022.1121845945987753430.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=hayeswang@realtek.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mario.limonciello@dell.com \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®