From: Christoph Hellwig <hch@infradead.org>
To: Palmer Dabbelt <palmer@sifive.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, patches@groups.riscv.org,
Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH 1/2] asm-generic: Add a generic set_handle_irq
Date: Thu, 18 Jan 2018 07:45:13 -0800 [thread overview]
Message-ID: <20180118154513.GA2678@infradead.org> (raw)
In-Reply-To: <20180118154005.24994-2-palmer@sifive.com>
I think this should not be asm-generic and lib, but kernel/irq/handle.c
and include/linux/irq.h, under the CONFIG_MULTI_IRQ_HANDLER symbol
already used by arm.
Also for completeness of the series please convert arm, arm64 and
openrisc over to the generic version. Last but not least I think
handle_arch_irq needs to be marked as __ro_after_init as a security
hardening measure.
next prev parent reply other threads:[~2018-01-18 16:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 15:40 Use arm64's scheme for registering first-level IRQ handlers on RISC-V Palmer Dabbelt
2018-01-18 15:40 ` [PATCH 1/2] asm-generic: Add a generic set_handle_irq Palmer Dabbelt
2018-01-18 15:45 ` Christoph Hellwig [this message]
2018-01-25 3:08 ` [patches] " Palmer Dabbelt
2018-01-18 15:40 ` [PATCH 2/2] RISC-V: Move to the new asm-generic IRQ handler Palmer Dabbelt
2018-01-18 16:43 ` Use arm64's scheme for registering first-level IRQ handlers on RISC-V Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118154513.GA2678@infradead.org \
--to=hch@infradead.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=palmer@sifive.com \
--cc=patches@groups.riscv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome