* [PATCH] auxdisplay: img-ascii-lcd: fix typo on select SYSCON/MFD_SYSCON
@ 2018-01-18 20:13 Corentin Labbe
2018-02-08 15:58 ` Miguel Ojeda
0 siblings, 1 reply; 3+ messages in thread
From: Corentin Labbe @ 2018-01-18 20:13 UTC (permalink / raw)
To: miguel.ojeda.sandonis; +Cc: linux-kernel, Corentin Labbe
img-ascii-lcd select un-existing SYSCON kconfig name.
This patch fix this error by using the correct MFD_SYSCON kconfig name.
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
drivers/auxdisplay/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
index 2c2ed9cf8796..d9ab60ed6c9b 100644
--- a/drivers/auxdisplay/Kconfig
+++ b/drivers/auxdisplay/Kconfig
@@ -138,7 +138,7 @@ config IMG_ASCII_LCD
tristate "Imagination Technologies ASCII LCD Display"
depends on HAS_IOMEM
default y if MIPS_MALTA || MIPS_SEAD3
- select SYSCON
+ select MFD_SYSCON
help
Enable this to support the simple ASCII LCD displays found on
development boards such as the MIPS Boston, MIPS Malta & MIPS SEAD3
--
2.13.6
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] auxdisplay: img-ascii-lcd: fix typo on select SYSCON/MFD_SYSCON
2018-01-18 20:13 [PATCH] auxdisplay: img-ascii-lcd: fix typo on select SYSCON/MFD_SYSCON Corentin Labbe
@ 2018-02-08 15:58 ` Miguel Ojeda
2018-02-12 13:54 ` Miguel Ojeda
0 siblings, 1 reply; 3+ messages in thread
From: Miguel Ojeda @ 2018-02-08 15:58 UTC (permalink / raw)
To: Corentin Labbe; +Cc: linux-kernel, paul.burton, Ralf Baechle
On Thu, Jan 18, 2018 at 9:13 PM, Corentin Labbe
<clabbe.montjoie@gmail.com> wrote:
> img-ascii-lcd select un-existing SYSCON kconfig name.
> This patch fix this error by using the correct MFD_SYSCON kconfig name.
>
CC'ing Paul & Ralf in case they want to ack.
The mistake seems to be in the tree since the addition of the driver
in 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple ASCII
LCD displays").
Acked-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Thanks,
Miguel
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> drivers/auxdisplay/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> index 2c2ed9cf8796..d9ab60ed6c9b 100644
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -138,7 +138,7 @@ config IMG_ASCII_LCD
> tristate "Imagination Technologies ASCII LCD Display"
> depends on HAS_IOMEM
> default y if MIPS_MALTA || MIPS_SEAD3
> - select SYSCON
> + select MFD_SYSCON
> help
> Enable this to support the simple ASCII LCD displays found on
> development boards such as the MIPS Boston, MIPS Malta & MIPS SEAD3
> --
> 2.13.6
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] auxdisplay: img-ascii-lcd: fix typo on select SYSCON/MFD_SYSCON
2018-02-08 15:58 ` Miguel Ojeda
@ 2018-02-12 13:54 ` Miguel Ojeda
0 siblings, 0 replies; 3+ messages in thread
From: Miguel Ojeda @ 2018-02-12 13:54 UTC (permalink / raw)
To: Corentin Labbe; +Cc: linux-kernel, paul.burton, Ralf Baechle
On Thu, Feb 8, 2018 at 4:58 PM, Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
> On Thu, Jan 18, 2018 at 9:13 PM, Corentin Labbe
> <clabbe.montjoie@gmail.com> wrote:
>> img-ascii-lcd select un-existing SYSCON kconfig name.
>> This patch fix this error by using the correct MFD_SYSCON kconfig name.
>>
>
> CC'ing Paul & Ralf in case they want to ack.
>
> The mistake seems to be in the tree since the addition of the driver
> in 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple ASCII
> LCD displays").
>
> Acked-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
>
I will pick this one up in my queue.
> Thanks,
> Miguel
>
>> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
>> ---
>> drivers/auxdisplay/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
>> index 2c2ed9cf8796..d9ab60ed6c9b 100644
>> --- a/drivers/auxdisplay/Kconfig
>> +++ b/drivers/auxdisplay/Kconfig
>> @@ -138,7 +138,7 @@ config IMG_ASCII_LCD
>> tristate "Imagination Technologies ASCII LCD Display"
>> depends on HAS_IOMEM
>> default y if MIPS_MALTA || MIPS_SEAD3
>> - select SYSCON
>> + select MFD_SYSCON
>> help
>> Enable this to support the simple ASCII LCD displays found on
>> development boards such as the MIPS Boston, MIPS Malta & MIPS SEAD3
>> --
>> 2.13.6
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-12 13:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-18 20:13 [PATCH] auxdisplay: img-ascii-lcd: fix typo on select SYSCON/MFD_SYSCON Corentin Labbe
2018-02-08 15:58 ` Miguel Ojeda
2018-02-12 13:54 ` Miguel Ojeda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®