From: ulrik.debie-os@e2big.org
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Aaron Ma <aaron.ma@canonical.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: trackpoint - force 3 buttons if 0 button is reported
Date: Sun, 21 Jan 2018 21:10:50 +0100 [thread overview]
Message-ID: <20180121201049.GA23310@beacon.debie> (raw)
In-Reply-To: <20180116230713.rppztybwe5ufhoxo@dtor-ws>
On Tue, Jan 16, 2018 at 03:07:13PM -0800, Dmitry Torokhov wrote:
Hi Dmitry,
>
> On Sat, Jan 13, 2018 at 10:34:19AM +0800, Aaron Ma wrote:
> > Will your patch go to stable kernel?
> > If yes, that's fine.
>
> Hmm, it looks like we need this patch after all as we do have screwy
> Lenovos with apparently 0x01 devices reporting 0 buttons. From
> https://bugzilla.kernel.org/show_bug.cgi?id=196253
>
> thinkpad_acpi: ThinkPad BIOS R0DET87W (1.87 ), EC unknown
> thinkpad_acpi: Lenovo ThinkPad E470, model 20H1004SGE
>
> psmouse serio2: trackpoint: IBM TrackPoint firmware: 0x0e, buttons: 0/0
>
> I'll ask them to try my patch and if it is indeed 0x01 device I'll apply
> your patch.
It is quite strange. In the past,for commit 293b915fd9be
"Input: trackpoint - assume 3 buttons when buttons detection fails" there was
success reported for lenovo e470 and I see the same success report in that
bugzilla ticket. I can also report success on lenovo e570.
But some seem to have problems, could it be that they are not including that
commit in the kernel they are running ? Or did a bios upgrade change the
behaviour ?
It would be best when we have a confirmation from a e470 owner that without the
proposed patch from Aaron the middle button does not work on his e470, and it
works with it.
Kind regards,
Ulrik
next prev parent reply other threads:[~2018-01-21 20:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 6:46 Aaron Ma
2018-01-12 8:39 ` Dmitry Torokhov
2018-01-12 12:45 ` Aaron Ma
2018-01-12 18:18 ` Dmitry Torokhov
2018-01-13 2:34 ` Aaron Ma
2018-01-16 23:07 ` Dmitry Torokhov
2018-01-21 20:10 ` ulrik.debie-os [this message]
2018-01-21 21:14 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180121201049.GA23310@beacon.debie \
--to=ulrik.debie-os@e2big.org \
--cc=aaron.ma@canonical.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®