From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: arkadis@mellanox.com, jiri@mellanox.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] devlink: fix memory leak on 'resource'
Date: Mon, 22 Jan 2018 09:27:37 -0500 (EST) [thread overview]
Message-ID: <20180122.092737.278179232055886032.davem@davemloft.net> (raw)
In-Reply-To: <20180122103119.4801-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Mon, 22 Jan 2018 10:31:19 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently, if the call to devlink_resource_find returns null then
> the error exit path does not free the devlink_resource 'resource'
> and a memory leak occurs. Fix this by kfree'ing resource on the
> error exit path.
>
> Detected by CoverityScan, CID#1464184 ("Resource leak")
>
> Fixes: d9f9b9a4d05f ("devlink: Add support for resource abstraction")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks Colin.
prev parent reply other threads:[~2018-01-22 14:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 10:31 Colin King
2018-01-22 10:34 ` Jiri Pirko
2018-01-22 14:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180122.092737.278179232055886032.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arkadis@mellanox.com \
--cc=colin.king@canonical.com \
--cc=jiri@mellanox.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®