[PATCH] tracing: Block comments should align the * on each line

[PATCH] tracing: Block comments should align the * on each line

[Rohit Visavalia]

Resolved Block comments use * on subsequent lines checkpatch warning.
Issue found by checkpatch.

Signed-off-by: Rohit Visavalia <rohit.visavalia@softnautics.com>
---
 kernel/trace/trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 8e3f20a18a06..ad718932ff32 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -2380,7 +2380,7 @@ EXPORT_SYMBOL_GPL(trace_event_buffer_commit);
  *   trace_buffer_unlock_commit_regs()
  *   trace_event_buffer_commit()
  *   trace_event_raw_event_xxx()
-*/
+ */
 # define STACK_SKIP 3
 
 void trace_buffer_unlock_commit_regs(struct trace_array *tr,
-- 
2.16.1

Re: [PATCH] tracing: Block comments should align the * on each line

[Steven Rostedt]

On Thu, 25 Jan 2018 18:01:36 +0530
Rohit Visavalia <rohit.visavalia@softnautics.com> wrote:

> Resolved Block comments use * on subsequent lines checkpatch warning.
> Issue found by checkpatch.
>

This should go through the trivial tree.

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve
 
> Signed-off-by: Rohit Visavalia <rohit.visavalia@softnautics.com>
> ---
>  kernel/trace/trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 8e3f20a18a06..ad718932ff32 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -2380,7 +2380,7 @@ EXPORT_SYMBOL_GPL(trace_event_buffer_commit);
>   *   trace_buffer_unlock_commit_regs()
>   *   trace_event_buffer_commit()
>   *   trace_event_raw_event_xxx()
> -*/
> + */
>  # define STACK_SKIP 3
>  
>  void trace_buffer_unlock_commit_regs(struct trace_array *tr,

Re: [PATCH] tracing: Block comments should align the * on each line

[Steven Rostedt]

Bah, this was suppose to go to trivial@kernel.org, not
trivial@vger.kernel.org.

-- Steve


On Thu, 25 Jan 2018 12:05:52 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Thu, 25 Jan 2018 18:01:36 +0530
> Rohit Visavalia <rohit.visavalia@softnautics.com> wrote:
> 
> > Resolved Block comments use * on subsequent lines checkpatch warning.
> > Issue found by checkpatch.
> >  
> 
> This should go through the trivial tree.
> 
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> 
> -- Steve
>  
> > Signed-off-by: Rohit Visavalia <rohit.visavalia@softnautics.com>
> > ---
> >  kernel/trace/trace.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > index 8e3f20a18a06..ad718932ff32 100644
> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -2380,7 +2380,7 @@ EXPORT_SYMBOL_GPL(trace_event_buffer_commit);
> >   *   trace_buffer_unlock_commit_regs()
> >   *   trace_event_buffer_commit()
> >   *   trace_event_raw_event_xxx()
> > -*/
> > + */
> >  # define STACK_SKIP 3
> >  
> >  void trace_buffer_unlock_commit_regs(struct trace_array *tr,  
> 

Re: [PATCH] tracing: Block comments should align the * on each line

[Steven Rostedt]

Yes but still Cc me.

-- Steve


On January 29, 2018 6:55:26 AM GMT+01:00, Rohit Visavalia <rohit.visavalia@softnautics.com> wrote:
>Hi Steve,
>
>Thanks for the review.
>
>Do you want me to resend the patch with v2 version to
>trivial@kernel.org ?
>
>Thanks,
>Rohit
>
>>
>________________________________
>> From: Rohit Visavalia
>> Sent: Monday, January 29, 2018 11:10 AM
>> To: Steven Rostedt
>> Cc: mingo@redhat.com; linux-kernel@vger.kernel.org;
>trivial@kernel.org
>> Subject: Re: [PATCH] tracing: Block comments should align the * on
>each line
>>
>
>> Hi Steve,
>
>>
>
>> Thanks for the review.
>
>>
>
>> Do you want me to resend the patch with v2 version to
>trivial@kernel.org ?
>
>>
>
>> Thanks,
>
>> Rohit
>
>>
>>
>>
>________________________________
>> From: Steven Rostedt <rostedt@goodmis.org>
>> Sent: Thursday, January 25, 2018 10:44 PM
>> To: Rohit Visavalia
>> Cc: mingo@redhat.com; linux-kernel@vger.kernel.org;
>trivial@kernel.org
>> Subject: Re: [PATCH] tracing: Block comments should align the * on
>each line
>>
>>
>> Bah, this was suppose to go to trivial@kernel.org, not
>> trivial@vger.kernel.org.
>>
>> -- Steve
>>
>>
>> On Thu, 25 Jan 2018 12:05:52 -0500
>> Steven Rostedt <rostedt@goodmis.org> wrote:
>>
>> > On Thu, 25 Jan 2018 18:01:36 +0530
>> > Rohit Visavalia <rohit.visavalia@softnautics.com> wrote:
>> >
>> > > Resolved Block comments use * on subsequent lines checkpatch
>warning.
>> > > Issue found by checkpatch.
>> > >
>> >
>> > This should go through the trivial tree.
>> >
>> > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>> >
>> > -- Steve
>> >
>> > > Signed-off-by: Rohit Visavalia <rohit.visavalia@softnautics.com>
>> > > ---
>> > >  kernel/trace/trace.c | 2 +-
>> > >  1 file changed, 1 insertion(+), 1 deletion(-)
>> > >
>> > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
>> > > index 8e3f20a18a06..ad718932ff32 100644
>> > > --- a/kernel/trace/trace.c
>> > > +++ b/kernel/trace/trace.c
>> > > @@ -2380,7 +2380,7 @@
>EXPORT_SYMBOL_GPL(trace_event_buffer_commit);
>> > >   *   trace_buffer_unlock_commit_regs()
>> > >   *   trace_event_buffer_commit()
>> > >   *   trace_event_raw_event_xxx()
>> > > -*/
>> > > + */
>> > >  # define STACK_SKIP 3
>> > >
>> > >  void trace_buffer_unlock_commit_regs(struct trace_array *tr,
>> >
>>

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.