From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ulf Magnusson <ulfalizer@gmail.com>
Cc: devel@driverdev.osuosl.org,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
"Luis R . Rodriguez" <mcgrof@kernel.org>
Subject: Re: [PATCH 05/10] Staging: rtl8192e: kconfig: Remove empty help text
Date: Wed, 31 Jan 2018 11:46:20 +0300 [thread overview]
Message-ID: <20180131084620.kkok5rpfbqakhyps@mwanda> (raw)
In-Reply-To: <CAFkk2KS0KQtnVB42tg1M3d1hR+APT7H99dZuzMPoCO63emO3hg@mail.gmail.com>
On Wed, Jan 31, 2018 at 09:41:24AM +0100, Ulf Magnusson wrote:
> On Wed, Jan 31, 2018 at 9:06 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Tue, Jan 30, 2018 at 08:05:27PM +0100, Ulf Magnusson wrote:
> >> In preparation for adding a warning ("kconfig: Warn if help text is
> >> blank"): https://lkml.org/lkml/2018/1/30/516
> >>
> >
> > Please don't start the boddy of the email in the middle of a sentence.
> >
> > It looks like this:
> >
> > https://marc.info/?l=linux-driver-devel&m=151733925532413&w=2
> >
> > Notice how the subject is up above the From, Date, and Message-id email
> > headers? It's totally disconnected from the body of the email.
> >
> > regards,
> > dan carpenter
>
> The 'this is in...' was implied. I'll try to be less of a sloppy bastard.
>
I do feel that patch descriptions should say what the patch does as well
as why. Right now the subject says what but I normally read either the
body or the subject but not both.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-01-31 8:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180130190555.6577-1-ulfalizer@gmail.com>
2018-01-30 19:05 ` [PATCH 01/10] net/sched: kconfig: Remove empty help texts Ulf Magnusson
2018-01-31 15:32 ` David Miller
2018-01-31 15:37 ` Masahiro Yamada
2018-01-31 15:43 ` David Miller
2018-01-31 17:28 ` Ulf Magnusson
2018-01-30 19:05 ` [PATCH 02/10] video: fbdev: kconfig: Remove empty help text Ulf Magnusson
2018-01-30 19:05 ` [PATCH 03/10] mmc: " Ulf Magnusson
2018-01-30 19:05 ` [PATCH 04/10] Staging: rtl8192u: " Ulf Magnusson
2018-01-30 19:05 ` [PATCH 05/10] Staging: rtl8192e: " Ulf Magnusson
2018-01-31 8:06 ` Dan Carpenter
2018-01-31 8:41 ` Ulf Magnusson
2018-01-31 8:46 ` Dan Carpenter [this message]
2018-01-31 9:52 ` Ulf Magnusson
2018-01-31 10:39 ` Dan Carpenter
2018-01-30 19:05 ` [PATCH 06/10] lib/Kconfig.debug: " Ulf Magnusson
2018-01-30 19:05 ` [PATCH 07/10] MIPS: BCM63XX: kconfig: " Ulf Magnusson
2018-01-30 19:05 ` [PATCH 08/10] MIPS: " Ulf Magnusson
2018-01-30 19:05 ` [PATCH 09/10] arm: vt8500: " Ulf Magnusson
2018-01-30 19:05 ` [PATCH 10/10] nios2: " Ulf Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180131084620.kkok5rpfbqakhyps@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=ulfalizer@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®