* [PATCH] gfs2: select CONFIG_LIBCRC32C
@ 2018-02-02 15:43 Arnd Bergmann
2018-02-02 15:52 ` Andreas Grünbacher
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-02-02 15:43 UTC (permalink / raw)
To: Steven Whitehouse, Bob Peterson
Cc: Arnd Bergmann, Andreas Gruenbacher, cluster-devel, linux-kernel
The new crc32c logic in gfs2_log_header_v2 causes a link
error without libcrc32c:
ERROR: "crc32c" [fs/gfs2/gfs2.ko] undefined!
While the original patch selected CONFIG_CRYPTO_CRC32C to deal
with this issue, it turned out to be the wrong symbol.
Fixes: c1696fb85d33 ("GFS2: Introduce new gfs2_log_header_v2")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/gfs2/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/gfs2/Kconfig b/fs/gfs2/Kconfig
index c0225d4b5435..3ed2b088dcfd 100644
--- a/fs/gfs2/Kconfig
+++ b/fs/gfs2/Kconfig
@@ -3,8 +3,7 @@ config GFS2_FS
depends on (64BIT || LBDAF)
select FS_POSIX_ACL
select CRC32
- select CRYPTO
- select CRYPTO_CRC32C
+ select LIBCRC32C
select QUOTACTL
select FS_IOMAP
help
--
2.9.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gfs2: select CONFIG_LIBCRC32C
2018-02-02 15:43 [PATCH] gfs2: select CONFIG_LIBCRC32C Arnd Bergmann
@ 2018-02-02 15:52 ` Andreas Grünbacher
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Grünbacher @ 2018-02-02 15:52 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Steven Whitehouse, Bob Peterson, Andreas Gruenbacher,
cluster-devel, Linux Kernel Mailing List
Hi Arnd,
2018-02-02 16:43 GMT+01:00 Arnd Bergmann <arnd@arndb.de>:
> The new crc32c logic in gfs2_log_header_v2 causes a link
> error without libcrc32c:
>
> ERROR: "crc32c" [fs/gfs2/gfs2.ko] undefined!
>
> While the original patch selected CONFIG_CRYPTO_CRC32C to deal
> with this issue, it turned out to be the wrong symbol.
>
> Fixes: c1696fb85d33 ("GFS2: Introduce new gfs2_log_header_v2")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> fs/gfs2/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/Kconfig b/fs/gfs2/Kconfig
> index c0225d4b5435..3ed2b088dcfd 100644
> --- a/fs/gfs2/Kconfig
> +++ b/fs/gfs2/Kconfig
> @@ -3,8 +3,7 @@ config GFS2_FS
> depends on (64BIT || LBDAF)
> select FS_POSIX_ACL
> select CRC32
> - select CRYPTO
> - select CRYPTO_CRC32C
> + select LIBCRC32C
> select QUOTACTL
> select FS_IOMAP
> help
> --
> 2.9.0
>
thanks for the fix, it's identical to what Bob has just asked Linus to
merge (https://lkml.org/lkml/2018/2/2/361).
Andreas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-02 15:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-02 15:43 [PATCH] gfs2: select CONFIG_LIBCRC32C Arnd Bergmann
2018-02-02 15:52 ` Andreas Grünbacher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®