From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kangmin Park <l4stpr0gr4m@gmail.com>
Cc: devel@driverdev.osuosl.org, arnd@arndb.de,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
justin@jvreeland.com, hdegoede@redhat.com, hadess@hadess.net,
joe@perches.com, davem@davemloft.net, Larry.Finger@lwfinger.net
Subject: Re: [PATCH] Resolve RF Type mismatch
Date: Wed, 7 Feb 2018 13:51:11 +0300 [thread overview]
Message-ID: <20180207105111.mle4uuq6ywj5yu26@mwanda> (raw)
In-Reply-To: <1517932633-7832-1-git-send-email-l4stpr0gr4m@gmail.com>
On Wed, Feb 07, 2018 at 12:57:13AM +0900, Kangmin Park wrote:
> From: pr0gr4m <l4stpr0gr4m@gmail.com>
No changelog, no sign-off. Changelogs are required but especially in
this case, it's not immediately obvious what this patch is about.
This patch has unrelated white space changes as well. Here is how the
rules work:
> - ODM_1T1R = 0,
> + ODM_1T1R = 0,
This are unrelated.
This white space change is on the same line so that's fine (it's
related).
> - else if ((rf_type == RF_1T2R) || (rf_type ==RF_2T2R))
> + else if ((rf_type == RF_1T2R) || (rf_type == RF_2T2R) || (rf_type == RF_2T2R_GREEN))
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-02-07 10:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 15:57 Kangmin Park
2018-02-06 16:08 ` Bastien Nocera
2018-02-06 16:31 ` Kangmin Park
2018-02-07 10:58 ` Dan Carpenter
2018-02-07 10:51 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-02-06 13:39 Kangmin Park
2018-02-06 14:37 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180207105111.mle4uuq6ywj5yu26@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=joe@perches.com \
--cc=justin@jvreeland.com \
--cc=l4stpr0gr4m@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®