From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kangmin Park <l4stpr0gr4m@gmail.com>
Cc: devel@driverdev.osuosl.org, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
justin@jvreeland.com, linux-kernel@vger.kernel.org,
hdegoede@redhat.com, Bastien Nocera <hadess@hadess.net>,
joe@perches.com, davem@davemloft.net, Larry.Finger@lwfinger.net
Subject: Re: [PATCH] Resolve RF Type mismatch
Date: Wed, 7 Feb 2018 13:58:53 +0300 [thread overview]
Message-ID: <20180207105853.2mul5qev4btg773i@mwanda> (raw)
In-Reply-To: <CAKW4uUzDA22u=URAaSvXT_tpEruu6i_R9VuGnX0nbu1OzM4_DA@mail.gmail.com>
Also the patch prefix is wrong in the email subject. It should say,
[PATCH] staging: rtl8723bs: Resolve RF Type mismatch
On Wed, Feb 07, 2018 at 01:31:48AM +0900, Kangmin Park wrote:
> Oops, Sorry for being stupid cuz of first time to use git email.
No problem. We were all newbies once. Send the email to yourself first
and try applying it with `git am`, then review the patch with
`git log -p`.
> RF_TYPE and ODM_RF_TYPE on staging/rtl8723bs is different from
> staging/rtlwifi 's - updated from v 4.14 -
> So, I try to update code on staging/rtl8723bs in comparison with
> staging/rtlwifi.
> commit message is "Update rf_type and odm_rf_type in comparison with
> drivers/staging/rtlwifi"
It needs a longer commit message than this. Also it probably needs to
be tested. I tried for about 10 seconds to find which patch you were
referring that updated staging/rtlwifi but I gave up. What is the git
hash and subject?
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-02-07 10:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 15:57 Kangmin Park
2018-02-06 16:08 ` Bastien Nocera
2018-02-06 16:31 ` Kangmin Park
2018-02-07 10:58 ` Dan Carpenter [this message]
2018-02-07 10:51 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2018-02-06 13:39 Kangmin Park
2018-02-06 14:37 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180207105853.2mul5qev4btg773i@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=joe@perches.com \
--cc=justin@jvreeland.com \
--cc=l4stpr0gr4m@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®