Re: [RFC][PATCH 5/6] selftests/ftrace: Add some missing glob checks

[Masami Hiramatsu <mhiramat@kernel.org>]

On Tue, 06 Feb 2018 17:43:43 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> 
> Al Viro discovered a bug in the glob ftrace filtering code where "*a*b" is
> treated the same as "a*b", and functions that would be selected by "*a*b"
> but not "a*b" are not selected with "*a*b".
> 
> Add tests for patterns "*a*b" and "a*b*" to the glob selftest.


Yeah, this is what we should have...

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thank you!

> 
> Link: http://lkml.kernel.org/r/20180127170748.GF13338@ZenIV.linux.org.uk
> 
> Cc: Shuah Khan <shuah@kernel.org>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> ---
>  tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc
> index 589d52b211b7..27a54a17da65 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc
> @@ -29,6 +29,12 @@ ftrace_filter_check '*schedule*' '^.*schedule.*$'
>  # filter by *, end match
>  ftrace_filter_check 'schedule*' '^schedule.*$'
>  
> +# filter by *mid*end
> +ftrace_filter_check '*aw*lock' '.*aw.*lock$'
> +
> +# filter by start*mid*
> +ftrace_filter_check 'mutex*try*' '^mutex.*try.*'
> +
>  # Advanced full-glob matching feature is recently supported.
>  # Skip the tests if we are sure the kernel does not support it.
>  if grep -q 'accepts: .* glob-matching-pattern' README ; then
> -- 
> 2.15.1
> 
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>