mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Cosmin Samoila <cosmin.samoila@nxp.com>
Cc: dl-linux-imx <linux-imx@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"wakasugi.jb@om.asahi-kasei.co.jp"
	<wakasugi.jb@om.asahi-kasei.co.jp>,
	"mihai.serban@gmail.com" <mihai.serban@gmail.com>,
	"S.j. Wang" <shengjiu.wang@nxp.com>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"mihai.serban@nxp.com" <mihai.serban@nxp.com>
Subject: Re: [PATCH] ASoC: codecs: Add support for AK4458 DAC driver
Date: Tue, 13 Feb 2018 11:55:37 +0000	[thread overview]
Message-ID: <20180213115537.GB5988@sirena.org.uk> (raw)
In-Reply-To: <1518513744.25655.8.camel@nxp.com>

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

On Tue, Feb 13, 2018 at 09:22:24AM +0000, Cosmin Samoila wrote:

> This is used to set the codec in Manual Setting Mode, meaning that
> the default sampling speed is set based on DFS0 and DFS1 bits. In
> Auto Setting Mode, the MCLK frequency is detected automatically and
> DFS bits are ignored.

But why is it a compile time option?

> This compile time option is used to know when to set the ACKS bit in
> init_reg function that switches between modes.
> At this moment we are only using Auto Mode and I can remove it if
> you think is not necessary.

Yes, just remove it - if there needs to be some control it should
probably be done by the machine driver, or through DT.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2018-02-13 11:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-31 13:20 Cosmin-Gabriel Samoila
2018-01-31 17:03 ` Mark Brown
2018-02-09 10:22   ` Cosmin Samoila
2018-02-09 15:47     ` Mark Brown
2018-02-13  9:22   ` Cosmin Samoila
2018-02-13 11:55     ` Mark Brown [this message]
2018-02-05  6:08 ` Rob Herring
2018-02-12 12:47 ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180213115537.GB5988@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=cosmin.samoila@nxp.com \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mihai.serban@gmail.com \
    --cc=mihai.serban@nxp.com \
    --cc=shengjiu.wang@nxp.com \
    --cc=wakasugi.jb@om.asahi-kasei.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®