From: "Matias Bjørling" <mb@lightnvm.io>
To: hch@lst.de, keith.busch@intel.com
Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
javier@cnexlabs.com, "Matias Bjørling" <mb@lightnvm.io>
Subject: [RFC PATCH 0/1] nvme: implement get log page offset and dwords
Date: Tue, 13 Feb 2018 13:49:15 +0100 [thread overview]
Message-ID: <20180213124916.28653-1-mb@lightnvm.io> (raw)
This patch introduces support for get log page offset and extends
the number of dwords to be 32 bits.
A function is introduced that takes the offset and implements the
support. This is needed for ocssd to retrieve the report chunk log
page, which can span a couple of megabytes.
The patch is based on Javier's report chunk implementation patch,
and is generalized to make it part of the nvme core. A follow up
patch will expose the extended function and let the lightnvm module
call it to retrieve the report chunk log page.
A couple of questions with respect to the function:
1. Should we check the offset in the extended function to be dword
aligned?
2. Verify that when offset is defined, the nvme controller version
is at least 1.2.1?
3. Handle requests that are larger than supported by the mdts field?
My take is that the caller should handle all of the above.
Thanks!
Matias Bjørling (1):
nvme: implement log page low/high offset and dwords
drivers/nvme/host/core.c | 36 ++++++++++++++++++++++++------------
1 file changed, 24 insertions(+), 12 deletions(-)
--
2.11.0
next reply other threads:[~2018-02-13 12:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 12:49 Matias Bjørling [this message]
2018-02-13 12:49 ` [PATCH 1/1] nvme: implement log page low/high " Matias Bjørling
2018-02-13 13:47 ` Johannes Thumshirn
2018-02-13 13:53 ` Matias Bjørling
2018-02-26 11:21 ` Javier Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213124916.28653-1-mb@lightnvm.io \
--to=mb@lightnvm.io \
--cc=hch@lst.de \
--cc=javier@cnexlabs.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®