From: "Matias Bjørling" <mb@lightnvm.io>
To: Johannes Thumshirn <jthumshirn@suse.de>,
hch@lst.de, keith.busch@intel.com
Cc: javier@cnexlabs.com, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/1] nvme: implement log page low/high offset and dwords
Date: Tue, 13 Feb 2018 14:53:01 +0100 [thread overview]
Message-ID: <a3b14909-0f9a-b0b3-876e-eb9722b528d1@lightnvm.io> (raw)
In-Reply-To: <1518529671.3592.9.camel@suse.de>
On 02/13/2018 02:47 PM, Johannes Thumshirn wrote:
> On Tue, 2018-02-13 at 13:49 +0100, Matias Bjørling wrote:
>> +int nvme_get_log_ext(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
>> + u8 log_page, void *log,
>> + size_t size, size_t offset)
>> +{
>> + struct nvme_command c = { };
>> + unsigned long dwlen = (size / 4) - 1;
>
> Consulting my long gone maths knowledge suggests the parantheses aren't
> really needed here.
>
Heh, you're right. However, it does make it a bit more readable? The
untrained eye would properly mess it up was my thinking for keeping them.
next prev parent reply other threads:[~2018-02-13 13:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 12:49 [RFC PATCH 0/1] nvme: implement get log page " Matias Bjørling
2018-02-13 12:49 ` [PATCH 1/1] nvme: implement log page low/high " Matias Bjørling
2018-02-13 13:47 ` Johannes Thumshirn
2018-02-13 13:53 ` Matias Bjørling [this message]
2018-02-26 11:21 ` Javier Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3b14909-0f9a-b0b3-876e-eb9722b528d1@lightnvm.io \
--to=mb@lightnvm.io \
--cc=hch@lst.de \
--cc=javier@cnexlabs.com \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®