mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [RFC PATCH martinbrandenburg] orangefs: orangefs_write_inode() can be static
  2018-02-13 20:12 [martinbrandenburg:for-next 13/13] fs/orangefs/super.c:153:5: sparse: symbol 'orangefs_write_inode' was not declared. Should it be static? kbuild test robot
@ 2018-02-13 20:12 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2018-02-13 20:12 UTC (permalink / raw)
  To: Martin Brandenburg; +Cc: kbuild-all, Mike Marshall, devel, linux-kernel


Fixes: 525e7273bc80 ("orangefs: let setattr write to cached inode")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 super.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/orangefs/super.c b/fs/orangefs/super.c
index 49bb1ce..c38310c 100644
--- a/fs/orangefs/super.c
+++ b/fs/orangefs/super.c
@@ -150,7 +150,7 @@ static void orangefs_destroy_inode(struct inode *inode)
 	call_rcu(&inode->i_rcu, orangefs_i_callback);
 }
 
-int orangefs_write_inode(struct inode *inode, struct writeback_control *wbc)
+static int orangefs_write_inode(struct inode *inode, struct writeback_control *wbc)
 {
 	struct iattr iattr;
 	gossip_debug(GOSSIP_SUPER_DEBUG, "orangefs_write_inode\n");

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [martinbrandenburg:for-next 13/13] fs/orangefs/super.c:153:5: sparse: symbol 'orangefs_write_inode' was not declared. Should it be static?
@ 2018-02-13 20:12 kbuild test robot
  2018-02-13 20:12 ` [RFC PATCH martinbrandenburg] orangefs: orangefs_write_inode() can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2018-02-13 20:12 UTC (permalink / raw)
  To: Martin Brandenburg; +Cc: kbuild-all, Mike Marshall, devel, linux-kernel

tree:   https://github.com/martinbrandenburg/linux for-next
head:   525e7273bc80995f5bcfdc2780b870aa3ab37a18
commit: 525e7273bc80995f5bcfdc2780b870aa3ab37a18 [13/13] orangefs: let setattr write to cached inode
reproduce:
        # apt-get install sparse
        git checkout 525e7273bc80995f5bcfdc2780b870aa3ab37a18
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> fs/orangefs/super.c:153:5: sparse: symbol 'orangefs_write_inode' was not declared. Should it be

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-02-13 20:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-13 20:12 [martinbrandenburg:for-next 13/13] fs/orangefs/super.c:153:5: sparse: symbol 'orangefs_write_inode' was not declared. Should it be static? kbuild test robot
2018-02-13 20:12 ` [RFC PATCH martinbrandenburg] orangefs: orangefs_write_inode() can be static kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®