From: Lukas Senger <lukas@fridolin.com>
To: Rodolfo Giometti <giometti@enneenne.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] pps-gpio: Avoid flooding syslog
Date: Thu, 15 Feb 2018 16:12:38 +0100 [thread overview]
Message-ID: <20180215161238.23e0c117@dinghy.localdomain> (raw)
In-Reply-To: <6c424674-e8f0-eaf1-c056-889e354b43b7@enneenne.com>
> Why a void function? You should use it to toggle echoing GPIO... =8-o
RFC 2783 says to generate the echo pulse "as rapidly as possible" which
is why I do the toggling in the irq handler. However this leaves the
default echo function installed which just floods syslog.
Another problem with this patch is that it also is against my old one
and not against current kernel code.
Cheers,
Lukas
next prev parent reply other threads:[~2018-02-15 15:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 15:58 [PATCH] pps-gpio: implement echo pulses Lukas Senger
2018-02-07 9:09 ` Rodolfo Giometti
2018-02-15 12:59 ` Lukas Senger
2018-02-15 12:59 ` [PATCH 1/2] pps-gpio: Avoid flooding syslog Lukas Senger
2018-02-15 13:34 ` Rodolfo Giometti
2018-02-15 15:12 ` Lukas Senger [this message]
2018-02-15 15:36 ` Rodolfo Giometti
2018-02-15 19:48 ` Lukas Senger
2018-02-15 12:59 ` [PATCH 2/2] pps-gpio: Set echo GPIO pin via devicetree Lukas Senger
2018-02-15 13:43 ` Rodolfo Giometti
2018-02-15 15:08 ` Lukas Senger
2018-02-15 15:33 ` Rodolfo Giometti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215161238.23e0c117@dinghy.localdomain \
--to=lukas@fridolin.com \
--cc=giometti@enneenne.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®