From: Rodolfo Giometti <giometti@enneenne.com>
To: Lukas Senger <lukas@fridolin.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] pps-gpio: Avoid flooding syslog
Date: Thu, 15 Feb 2018 16:36:25 +0100 [thread overview]
Message-ID: <a9b965fe-fee2-3aab-0f2c-681d2835070c@enneenne.com> (raw)
In-Reply-To: <20180215161238.23e0c117@dinghy.localdomain>
On 15/02/18 16:12, Lukas Senger wrote:
>
>> Why a void function? You should use it to toggle echoing GPIO... =8-o
>
> RFC 2783 says to generate the echo pulse "as rapidly as possible" which
> is why I do the toggling in the irq handler. However this leaves the
> default echo function installed which just floods syslog.
The pps_event() function does it for you in a beauty-and-clear way by using the
info.echo() function. :-D
> Another problem with this patch is that it also is against my old one
> and not against current kernel code.
Yes, correct it please.
Ciao,
Rodolfo
--
HCE Engineering e-mail: giometti@hce-engineering.it
GNU/Linux Solutions giometti@enneenne.com
Linux Device Driver giometti@linux.it
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti
Cosino Project - the quick prototyping embedded system - www.cosino.it
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
next prev parent reply other threads:[~2018-02-15 15:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 15:58 [PATCH] pps-gpio: implement echo pulses Lukas Senger
2018-02-07 9:09 ` Rodolfo Giometti
2018-02-15 12:59 ` Lukas Senger
2018-02-15 12:59 ` [PATCH 1/2] pps-gpio: Avoid flooding syslog Lukas Senger
2018-02-15 13:34 ` Rodolfo Giometti
2018-02-15 15:12 ` Lukas Senger
2018-02-15 15:36 ` Rodolfo Giometti [this message]
2018-02-15 19:48 ` Lukas Senger
2018-02-15 12:59 ` [PATCH 2/2] pps-gpio: Set echo GPIO pin via devicetree Lukas Senger
2018-02-15 13:43 ` Rodolfo Giometti
2018-02-15 15:08 ` Lukas Senger
2018-02-15 15:33 ` Rodolfo Giometti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9b965fe-fee2-3aab-0f2c-681d2835070c@enneenne.com \
--to=giometti@enneenne.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@fridolin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®