From: Hans de Goede <hdegoede@redhat.com>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>, linux-kernel@vger.kernel.org
Subject: [PATCH 4/9] ASoC: Intel: sst: Remove unused STREAM_DECODE and STREAM_RESET states
Date: Sun, 18 Feb 2018 23:01:41 +0100 [thread overview]
Message-ID: <20180218220146.22485-5-hdegoede@redhat.com> (raw)
In-Reply-To: <20180218220146.22485-1-hdegoede@redhat.com>
STREAM_DECODE is completely unused, status == STREAM_RESET was checked
for, but never set, remove both.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
sound/soc/intel/atom/sst/sst.h | 4 +---
sound/soc/intel/atom/sst/sst_drv_interface.c | 19 -------------------
2 files changed, 1 insertion(+), 22 deletions(-)
diff --git a/sound/soc/intel/atom/sst/sst.h b/sound/soc/intel/atom/sst/sst.h
index 164b0f674c20..f4fd442080b2 100644
--- a/sound/soc/intel/atom/sst/sst.h
+++ b/sound/soc/intel/atom/sst/sst.h
@@ -65,9 +65,7 @@ enum sst_stream_states {
STREAM_UN_INIT = 0, /* Freed/Not used stream */
STREAM_RUNNING = 1, /* Running */
STREAM_PAUSED = 2, /* Paused stream */
- STREAM_DECODE = 3, /* stream is in decoding only state */
- STREAM_INIT = 4, /* stream init, waiting for data */
- STREAM_RESET = 5, /* force reset on recovery */
+ STREAM_INIT = 3, /* stream init, waiting for data */
};
enum sst_ram_type {
diff --git a/sound/soc/intel/atom/sst/sst_drv_interface.c b/sound/soc/intel/atom/sst/sst_drv_interface.c
index 71af5449be90..6a8b253c58d2 100644
--- a/sound/soc/intel/atom/sst/sst_drv_interface.c
+++ b/sound/soc/intel/atom/sst/sst_drv_interface.c
@@ -238,16 +238,7 @@ static int sst_cdev_close(struct device *dev, unsigned int str_id)
return -EINVAL;
}
- if (stream->status == STREAM_RESET) {
- dev_dbg(dev, "stream in reset state...\n");
- stream->status = STREAM_UN_INIT;
-
- retval = 0;
- goto put;
- }
-
retval = sst_free_stream(ctx, str_id);
-put:
stream->compr_cb_param = NULL;
stream->compr_cb = NULL;
@@ -256,7 +247,6 @@ static int sst_cdev_close(struct device *dev, unsigned int str_id)
dev_dbg(dev, "End\n");
return retval;
-
}
static int sst_cdev_ack(struct device *dev, unsigned int str_id,
@@ -486,16 +476,7 @@ static int sst_close_pcm_stream(struct device *dev, unsigned int str_id)
return -EINVAL;
}
- if (stream->status == STREAM_RESET) {
- /* silently fail here as we have cleaned the stream earlier */
- dev_dbg(ctx->dev, "stream in reset state...\n");
-
- retval = 0;
- goto put;
- }
-
retval = free_stream_context(ctx, str_id);
-put:
stream->pcm_substream = NULL;
stream->status = STREAM_UN_INIT;
stream->period_elapsed = NULL;
--
2.14.3
next prev parent reply other threads:[~2018-02-18 22:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-18 22:01 [PATCH 0/9] ASoC: Intel: sst: Fix Bay Trail suspend/resume issues Hans de Goede
2018-02-18 22:01 ` [PATCH 1/9] ASoC: Intel: sst: Fix error-code check in sst_pause_stream() Hans de Goede
2018-02-19 13:47 ` Andy Shevchenko
2018-02-19 14:00 ` Hans de Goede
2018-02-18 22:01 ` [PATCH 2/9] ASoC: Intel: sst: Remove 2 unused members from stream_info struct Hans de Goede
2018-02-18 22:01 ` [PATCH 3/9] ASoC: Intel: sst: Remove unnecessary sst_init_stream() function Hans de Goede
2018-02-18 22:01 ` Hans de Goede [this message]
2018-02-18 22:01 ` [PATCH 5/9] ASoC: Intel: sst: Add sst_realloc_stream() function Hans de Goede
2018-02-18 22:01 ` [PATCH 6/9] ASoC: Intel: sst: Free streams on suspend, re-alloc on resume Hans de Goede
2018-02-19 13:51 ` Andy Shevchenko
2018-02-19 14:02 ` Hans de Goede
2018-02-19 16:29 ` Mark Brown
2018-02-19 16:32 ` Hans de Goede
2018-02-19 16:35 ` Mark Brown
2018-02-18 22:01 ` [PATCH 7/9] ASoc: rt5651: Fix regcache sync errors " Hans de Goede
2018-02-18 22:01 ` [PATCH 8/9] ASoC: Intel: bytcr_rt5640: Drop unwanted ignore_suspend settings Hans de Goede
2018-03-01 16:22 ` Mark Brown
2018-03-01 16:26 ` Hans de Goede
2018-03-01 16:48 ` Mark Brown
2018-03-01 16:58 ` Hans de Goede
2018-03-01 17:17 ` Mark Brown
2018-03-04 14:11 ` Hans de Goede
2018-03-05 13:50 ` Hans de Goede
2018-03-05 15:34 ` Mark Brown
2018-02-18 22:01 ` [PATCH 9/9] ASoC: Intel: bytcr_rt5651: " Hans de Goede
2018-02-19 13:53 ` [PATCH 0/9] ASoC: Intel: sst: Fix Bay Trail suspend/resume issues Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180218220146.22485-5-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®