Re: [PATCH 6/9] ASoC: Intel: sst: Free streams on suspend, re-alloc on resume

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 19-02-18 14:51, Andy Shevchenko wrote:
> On Mon, Feb 19, 2018 at 12:01 AM, Hans de Goede <hdegoede@redhat.com> wrote:
>> The Bay Trail SST-DSP firmware version looses track of all streams over a
>> suspend/resume, failing any attempts to resume and/or free streams, with
>> a SST_ERR_INVALID_STREAM_ID error.
>>
>> This commit adds support for free-ing the streams on suspend and
>> re-allocating them on resume, fixing suspend/resume issues on devices
>> using this firmware version.
>>
>> This new behavior gets triggered by a new flag in sst_platform_info which
>> only gets set on Bay Trail platforms.
>>
>> This has been tested on the following devices:
>> -Asus T100TA,    Bay Trail    + ALC5642 codec
>> -Ployer MOMO7W,  Bay Trail CR + ALC5652 codec
> 
> 
>>   /* Cherryview (Cherrytrail and Braswell) uses same mrfld dpcm fw as Baytrail,
>> - * so pdata is same as Baytrail.
>> + * so pdata is same as Baytrail, minus the streams_lost_on_suspend quirk.
>>    */
> 
> A nit, perhaps to fix multi line comment style as well?

The is the net/* style of multi-line comments which is used in quite a few
places in the sounds/soc dir. I think both styles are accepted under sound/soc?

Regards,

Hans