From: Dan Carpenter <dan.carpenter@oracle.com>
To: Quytelda Kahja <quytelda@tamalin.org>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH] Staging: gdm724x: LTE: Fix trailing open parenthesis code style issue.
Date: Mon, 19 Feb 2018 12:15:50 +0300 [thread overview]
Message-ID: <20180219091550.7nhyjfqvwob6cc2c@mwanda> (raw)
In-Reply-To: <20180216214008.17105-1-quytelda@tamalin.org>
On Fri, Feb 16, 2018 at 01:40:08PM -0800, Quytelda Kahja wrote:
> @@ -728,17 +731,21 @@ static void gdm_lte_pdn_table(struct net_device *dev, char *buf, int len)
> {
> struct nic *nic = netdev_priv(dev);
> struct hci_pdn_table_ind *pdn_table = (struct hci_pdn_table_ind *)buf;
> + struct gdm_endian *dft_endian;
> + struct gdm_endian *nic_endian;
>
> if (pdn_table->activate) {
> nic->pdn_table.activate = pdn_table->activate;
> - nic->pdn_table.dft_eps_id = gdm_dev32_to_cpu(
> - nic->phy_dev->get_endian(
> - nic->phy_dev->priv_dev),
> - pdn_table->dft_eps_id);
> - nic->pdn_table.nic_type = gdm_dev32_to_cpu(
> - nic->phy_dev->get_endian(
> - nic->phy_dev->priv_dev),
> - pdn_table->nic_type);
> +
> + dft_endian = nic->phy_dev->get_endian(nic->phy_dev->priv_dev);
> + nic_endian = nic->phy_dev->get_endian(nic->phy_dev->priv_dev);
We don't need both dft_endian abd nic_endian since they're the same
endianness. Otherwise, this is a nice cleanup.
> +
> + nic->pdn_table.dft_eps_id =
> + gdm_dev32_to_cpu(dft_endian,
> + pdn_table->dft_eps_id);
> + nic->pdn_table.nic_type =
> + gdm_dev32_to_cpu(nic_endian,
> + pdn_table->nic_type);
>
> netdev_info(dev, "pdn activated, nic_type=0x%x\n",
> nic->pdn_table.nic_type);
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-02-19 9:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 21:40 Quytelda Kahja
2018-02-19 9:15 ` Dan Carpenter [this message]
2018-02-21 10:20 ` [PATCH] Staging: gdm724x: LTE: Fix trailing open parentheses Quytelda Kahja
2018-02-21 10:43 ` Dan Carpenter
2018-02-21 13:12 ` [PATCH 1/2] Staging: gdm724x: Simplify the struct gdm_endian to a variable Quytelda Kahja
2018-02-21 13:12 ` [PATCH 2/2] Staging: gdm724x: LTE: Refactor gdm_lte_pdn_table() Quytelda Kahja
2018-02-21 13:21 ` [PATCH 1/2] Staging: gdm724x: Simplify the struct gdm_endian to a variable Dan Carpenter
2018-02-22 14:02 ` Greg KH
2018-02-23 1:16 ` Quytelda Kahja
2018-02-23 1:30 ` [PATCH 1/4] Staging: gdm724x: LTE: Fix trailing open parentheses Quytelda Kahja
2018-02-23 1:32 ` [PATCH 2/4] Staging: gdm724x: hci: Changed camel-case to snake-case Quytelda Kahja
2018-02-23 1:33 ` [PATCH 3/4] Staging: gdm724x: Simplify the struct gdm_endian to a variable Quytelda Kahja
2018-02-23 1:33 ` [PATCH 4/4] Staging: gdm724x: LTE: Refactor gdm_lte_pdn_table() Quytelda Kahja
2018-02-23 8:15 ` [PATCH 2/4] Staging: gdm724x: hci: Changed camel-case to snake-case Greg KH
2018-02-23 23:46 ` [PATCH] staging: gdm724x: hci: Remove unused struct sdu_header Quytelda Kahja
2018-02-19 17:05 ` [PATCH] Staging: gdm724x: LTE: Fix trailing open parenthesis code style issue Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180219091550.7nhyjfqvwob6cc2c@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quytelda@tamalin.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®