mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Quytelda Kahja <quytelda@tamalin.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: gdm724x: LTE: Fix trailing open parenthesis code style issue.
Date: Mon, 19 Feb 2018 18:05:38 +0100	[thread overview]
Message-ID: <20180219170538.GB18723@kroah.com> (raw)
In-Reply-To: <20180216214008.17105-1-quytelda@tamalin.org>

On Fri, Feb 16, 2018 at 01:40:08PM -0800, Quytelda Kahja wrote:
> Fix a coding style problem causing warnings from checkpatch.pl.
> 
> Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
> ---
>  drivers/staging/gdm724x/gdm_lte.c | 50 ++++++++++++++++++++++-----------------
>  1 file changed, 28 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c
> index 0527b0d1c1d0..ff3fed9c4a81 100644
> --- a/drivers/staging/gdm724x/gdm_lte.c
> +++ b/drivers/staging/gdm724x/gdm_lte.c
> @@ -204,9 +204,12 @@ static __sum16 icmp6_checksum(struct ipv6hdr *ipv6, u16 *ptr, int len)
>  	pseudo_header.ph.ph_nxt = ipv6->nexthdr;
>  
>  	w = (u16 *)&pseudo_header;
> -	for (i = 0; i < ARRAY_SIZE(pseudo_header.pa); i++)
> -		sum = csum_add(sum, csum_unfold(
> -					(__force __sum16)pseudo_header.pa[i]));
> +	for (i = 0; i < ARRAY_SIZE(pseudo_header.pa); i++) {
> +		__wsum tmp_sum;
> +
> +		tmp_sum = csum_unfold((__force __sum16)pseudo_header.pa[i]);
> +		sum = csum_add(sum, tmp_sum);
> +	}
>  
>  	w = ptr;
>  	while (len > 1) {
> @@ -510,18 +513,18 @@ static int gdm_lte_event_send(struct net_device *dev, char *buf, int len)
>  {
>  	struct nic *nic = netdev_priv(dev);
>  	struct hci_packet *hci = (struct hci_packet *)buf;
> +	struct gdm_endian *phy_endian;
>  	int idx;
> +	u16 cpu;
>  	int ret;
>  
>  	ret = sscanf(dev->name, "lte%d", &idx);
>  	if (ret != 1)
>  		return -EINVAL;
>  
> -	return netlink_send(lte_event.sock, idx, 0, buf,
> -			    gdm_dev16_to_cpu(
> -				    nic->phy_dev->get_endian(
> -					    nic->phy_dev->priv_dev), hci->len)
> -			    + HCI_HEADER_SIZE);
> +	phy_endian = nic->phy_dev->get_endian(nic->phy_dev->priv_dev);
> +	cpu = gdm_dev16_to_cpu(phy_endian, hci->len);
> +	return netlink_send(lte_event.sock, idx, 0, buf, cpu + HCI_HEADER_SIZE);
>  }
>  
>  static void gdm_lte_event_rcv(struct net_device *dev, u16 type,
> @@ -728,17 +731,21 @@ static void gdm_lte_pdn_table(struct net_device *dev, char *buf, int len)
>  {
>  	struct nic *nic = netdev_priv(dev);
>  	struct hci_pdn_table_ind *pdn_table = (struct hci_pdn_table_ind *)buf;
> +	struct gdm_endian *dft_endian;
> +	struct gdm_endian *nic_endian;
>  
>  	if (pdn_table->activate) {
>  		nic->pdn_table.activate = pdn_table->activate;
> -		nic->pdn_table.dft_eps_id = gdm_dev32_to_cpu(
> -						nic->phy_dev->get_endian(
> -							nic->phy_dev->priv_dev),
> -						pdn_table->dft_eps_id);
> -		nic->pdn_table.nic_type = gdm_dev32_to_cpu(
> -						nic->phy_dev->get_endian(
> -							nic->phy_dev->priv_dev),
> -						pdn_table->nic_type);
> +
> +		dft_endian = nic->phy_dev->get_endian(nic->phy_dev->priv_dev);
> +		nic_endian = nic->phy_dev->get_endian(nic->phy_dev->priv_dev);

These are the same values :(

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

      parent reply	other threads:[~2018-02-19 17:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-16 21:40 Quytelda Kahja
2018-02-19  9:15 ` Dan Carpenter
2018-02-21 10:20   ` [PATCH] Staging: gdm724x: LTE: Fix trailing open parentheses Quytelda Kahja
2018-02-21 10:43     ` Dan Carpenter
2018-02-21 13:12       ` [PATCH 1/2] Staging: gdm724x: Simplify the struct gdm_endian to a variable Quytelda Kahja
2018-02-21 13:12         ` [PATCH 2/2] Staging: gdm724x: LTE: Refactor gdm_lte_pdn_table() Quytelda Kahja
2018-02-21 13:21         ` [PATCH 1/2] Staging: gdm724x: Simplify the struct gdm_endian to a variable Dan Carpenter
2018-02-22 14:02         ` Greg KH
2018-02-23  1:16           ` Quytelda Kahja
2018-02-23  1:30             ` [PATCH 1/4] Staging: gdm724x: LTE: Fix trailing open parentheses Quytelda Kahja
2018-02-23  1:32             ` [PATCH 2/4] Staging: gdm724x: hci: Changed camel-case to snake-case Quytelda Kahja
2018-02-23  1:33               ` [PATCH 3/4] Staging: gdm724x: Simplify the struct gdm_endian to a variable Quytelda Kahja
2018-02-23  1:33               ` [PATCH 4/4] Staging: gdm724x: LTE: Refactor gdm_lte_pdn_table() Quytelda Kahja
2018-02-23  8:15               ` [PATCH 2/4] Staging: gdm724x: hci: Changed camel-case to snake-case Greg KH
2018-02-23 23:46                 ` [PATCH] staging: gdm724x: hci: Remove unused struct sdu_header Quytelda Kahja
2018-02-19 17:05 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180219170538.GB18723@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quytelda@tamalin.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®