* [PATCH] Staging: xgifb: fix lines should not end with open parenthesis in vb_setmode.c
@ 2018-02-16 18:42 Yash Omer
2018-02-19 17:04 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Yash Omer @ 2018-02-16 18:42 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, driverdev-devel, devel, linux-kernel
This patch fixes up line should not end with open parenthesis found by checkpatch.pl script.
Signed-off-by: Yash Omer <yashomer0007@gmail.com>
---
drivers/staging/xgifb/vb_setmode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
index 1fa0dc66406e..1d6ac724fd61 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -1228,8 +1228,8 @@ static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table,
return table[i].DATAPTR;
}
-static struct SiS_TVData const *XGI_GetTVPtr(
- unsigned short ModeIdIndex,
+static struct SiS_TVData const *XGI_GetTVPtr
+(unsigned short ModeIdIndex,
unsigned short RefreshRateTableIndex,
struct vb_device_info *pVBInfo)
{
--
2.14.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: xgifb: fix lines should not end with open parenthesis in vb_setmode.c
2018-02-16 18:42 [PATCH] Staging: xgifb: fix lines should not end with open parenthesis in vb_setmode.c Yash Omer
@ 2018-02-19 17:04 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2018-02-19 17:04 UTC (permalink / raw)
To: Yash Omer; +Cc: devel, driverdev-devel, linux-kernel, Larry.Finger
On Sat, Feb 17, 2018 at 12:12:36AM +0530, Yash Omer wrote:
> This patch fixes up line should not end with open parenthesis found by checkpatch.pl script.
>
> Signed-off-by: Yash Omer <yashomer0007@gmail.com>
> ---
> drivers/staging/xgifb/vb_setmode.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index 1fa0dc66406e..1d6ac724fd61 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -1228,8 +1228,8 @@ static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table,
> return table[i].DATAPTR;
> }
>
> -static struct SiS_TVData const *XGI_GetTVPtr(
> - unsigned short ModeIdIndex,
> +static struct SiS_TVData const *XGI_GetTVPtr
> +(unsigned short ModeIdIndex,
Ick, that's horrid looking now, don't you think?
Please don't change things to make them look worse :)
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-19 17:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-16 18:42 [PATCH] Staging: xgifb: fix lines should not end with open parenthesis in vb_setmode.c Yash Omer
2018-02-19 17:04 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®