mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, jonathankim@gctsemi.com,
	linux-kernel@vger.kernel.org, deanahn@gctsemi.com,
	Quytelda Kahja <quytelda@gmail.com>,
	Quytelda Kahja <quytelda@tamalin.org>
Subject: Re: [PATCH] Staging: gdm724x: hci: Changed camel-case to snake-case.
Date: Thu, 22 Feb 2018 14:44:21 +0100	[thread overview]
Message-ID: <20180222134421.GA19182@kroah.com> (raw)
In-Reply-To: <20180221104558.r7qgxyqshy37gej6@mwanda>

On Wed, Feb 21, 2018 at 01:45:58PM +0300, Dan Carpenter wrote:
> On Wed, Feb 21, 2018 at 02:39:28AM -0800, Quytelda Kahja wrote:
> > Changed a variable name from camel to snake case to fix a coding style
> > issue.
> > 
> > Signed-off-by: Quytelda Kahja <quytelda@gmail.com>
> > ---
> >  drivers/staging/gdm724x/hci_packet.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/gdm724x/hci_packet.h b/drivers/staging/gdm724x/hci_packet.h
> > index 22ce8b9477b6..f8837c7103ac 100644
> > --- a/drivers/staging/gdm724x/hci_packet.h
> > +++ b/drivers/staging/gdm724x/hci_packet.h
> > @@ -50,7 +50,7 @@ struct tlv {
> >  struct sdu_header {
> >  	__dev16 cmd_evt;
> >  	__dev16 len;
> > -	__dev32 dftEpsId;
> > +	__dev32 dft_eps_ID;
> 
> I bet this is a part of the user space ABI or there is a specific reason
> for the name to match the spec or something so it can't be changed...

This structure is not even used anywhere :(

Quytelda, can you just remove all unused structure definitions from this
driver?  That would be a much better patch here instead of changing a
structure field that no one uses.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

      parent reply	other threads:[~2018-02-22 13:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-21 10:39 Quytelda Kahja
2018-02-21 10:45 ` Dan Carpenter
2018-02-21 11:15   ` Quytelda Kahja
2018-02-21 12:18     ` Dan Carpenter
2018-02-22 13:44   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180222134421.GA19182@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=deanahn@gctsemi.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=jonathankim@gctsemi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quytelda@gmail.com \
    --cc=quytelda@tamalin.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®